Simplify Crystal::System::Fiber::RESERVED_STACK_SIZE initializer on Windows#15820
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom May 26, 2025
Merged
Conversation
ysbaddaden
approved these changes
May 23, 2025
Collaborator
ysbaddaden
left a comment
There was a problem hiding this comment.
What about LibC::DWORD.new!(0x10000) to skip the math overflow check?
Contributor
Author
|
The overflow check is not the issue here, that is still a complex initializer that requires |
Collaborator
|
Oh right, it's still a constant 🤦 |
straight-shoota
approved these changes
May 23, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibC::DWORD.new(0x10000)is a complex initializer, which on very rare occasions could completely halt the program:Maybe it was interfering with the event loop before fiber stacks could be checked out? This was especially observable on the recent ARM64 MSYS2 CI, but if you run a Hello World program in a shell loop the same also happens in a matter of seconds.