Conversation
✅ Deploy Preview for crystal-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/upcoming-release-1-17-0/8184/1 |
| Also, the `blocking` parameter is deprecated. It's not necessary to configure | ||
| in the constructor ([#15924]). It's still possible to change the mode after | ||
| creation with [`#blocking=`]. |
There was a problem hiding this comment.
Issue crystal-lang/crystal#15924 also deprecated #blocking and #blocking= and added Socket.set_blocking(fd, blocking) instead, with no replacement for IO::FileDescriptor (or File) because it's not portable... but we still want to have it, at least on IO::FileDescriptor and raise on Windows 🤔
There was a problem hiding this comment.
We actually haven't merged crystal-lang/crystal#15924 yet and despite the Docs theme, it is more than a documentation change, including several internal refactors and deprecations.
It all looks inconspicuous, but I'm nevertheless not comfortable merging such a change one day before the minor release.
So I think we should revert 1987aaa here.
Maybe we can extract some of the doc-only changes from crystal-lang/crystal#15924 to incorporate into 1.17.0.
The deprecations and refactors will have to wait for 1.18.0.
There was a problem hiding this comment.
Damn, I wish we'd have everything related to the blocking behavior in a single release 😭
Co-authored-by: Julien Portalier <julien@portalier.com>
This reverts commit 1987aaa.
beta-ziliani
left a comment
beta-ziliani
left a comment
There was a problem hiding this comment.
Only one real issue, the rest is just nitpicking
6 participants
Preview: https://deploy-preview-951--crystal-website.netlify.app/2025/07/16/1.17.0-released/
Changelog: crystal-lang/crystal#15900