Skip to content

Simplify Crystal::System::Fiber::RESERVED_STACK_SIZE initializer on Windows #15820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 2 commits into from
May 26, 2025
Merged

Simplify Crystal::System::Fiber::RESERVED_STACK_SIZE initializer on Windows #15820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c92a115
Simplify `Crystal::System::Fiber::RESERVED_STACK_SIZE` initializer on…
HertzDevil May 23, 2025
1585fb6
fixup
HertzDevil May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/crystal/system/win32/fiber.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ require "c/winnt"
module Crystal::System::Fiber
# stack size in bytes needed for last-minute error handling in case of a stack
# overflow
RESERVED_STACK_SIZE = LibC::DWORD.new(0x10000)
# FIXME: use `LibC::DWORD` explicitly (#15820)
RESERVED_STACK_SIZE = 0x10000_u32

def self.allocate_stack(stack_size, protect) : Void*
if stack_top = LibC.VirtualAlloc(nil, stack_size, LibC::MEM_RESERVE, LibC::PAGE_READWRITE)
Expand Down
Loading