Formatter: add & to yielding methods without a block parameter#12951
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Jan 16, 2023
Merged
Conversation
straight-shoota
approved these changes
Jan 15, 2023
This was referenced Jan 20, 2023
SamantazFox
added a commit
to SamantazFox/invidious
that referenced
this pull request
Jan 21, 2023
Changes added by crystal-lang/crystal#12951
16 tasks
straight-shoota
added a commit
to straight-shoota/crystal-book
that referenced
this pull request
Jan 25, 2023
Adds block argument to signature of yielding methods (crystal-lang/crystal#12951).
Contributor
|
This change introduces a small issue formatting a method with inlined comments def foo # my foo method
yield 42
endformats to def foo # my foo method(&)
yield 42
end |
Member
|
Thanks for reporting. I created a new issue #13091 to track this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves part of #8764.
This is not done to macros because they don't overload by block presence; all macros may be called with or without a block, regardless of whether the macro yields, whether the block parameter exists, and whether that parameter has a name.
0a4474a adds a total of 553 anonymous block parameters to the repository this way.