Apply formatter to Crystal examples#665
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Feb 8, 2023
Merged
Conversation
Adds block argument to signature of yielding methods (crystal-lang/crystal#12951).
✅ Deploy Preview for crystal-book ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
|
The |
Member
Author
|
Semantic changes to the specification belong in a separate PR. This is a purely formal fix and necessary to avoid CI failures. It should just be merged without delay. |
Member
|
I disagree. The formatting changed the way code is presented, and as such it must be fixed together. I prefer to keep the text coherent than CI happy. Happy to review a following PR to be merged at the same time though. |
Member
|
@straight-shoota can you review my added text? 🙇 |
beta-ziliani
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds block argument to signature of yielding methods (crystal-lang/crystal#12951).