Skip to content

Comments

chore: fix crystal-nightly compatibility#356

Merged
veelenga merged 4 commits intomasterfrom
chore/crystal-nightly
Feb 19, 2023
Merged

chore: fix crystal-nightly compatibility#356
veelenga merged 4 commits intomasterfrom
chore/crystal-nightly

Conversation

@veelenga
Copy link
Member

  • this specific test fails in master, example

@veelenga veelenga requested a review from Sija February 19, 2023 07:31
@veelenga veelenga self-assigned this Feb 19, 2023
@veelenga veelenga marked this pull request as draft February 19, 2023 07:41
@veelenga
Copy link
Member Author

Hard to say how to fix the formatter issue here. Crystal now reformats the docs and bad examples could be reformatted to the good ones.

In our case it tries to reformat this

# def foo
# yield 42
# end

into a valid case. See crystal-lang/crystal#12951

@Sija
Copy link
Member

Sija commented Feb 19, 2023

Hard to say how to fix the formatter issue here. Crystal now reformats the docs and bad examples could be reformatted to the good ones.

In our case it tries to reformat this

# def foo
# yield 42
# end

into a valid case. See crystal-lang/crystal#12951

These will need to use 4-spaces indentation instead of the backticks, since the indented code is not touched by the Crystal formatter.

@Sija Sija force-pushed the chore/crystal-nightly branch from 7a991b4 to 63a5498 Compare February 19, 2023 12:25
@Sija Sija added the refactor label Feb 19, 2023
@veelenga veelenga marked this pull request as ready for review February 19, 2023 12:52
@Sija
Copy link
Member

Sija commented Feb 19, 2023

Might land in 1.4.2 too, btw.

@veelenga veelenga merged commit 81177dc into master Feb 19, 2023
@veelenga veelenga deleted the chore/crystal-nightly branch February 19, 2023 16:06
@veelenga
Copy link
Member Author

Cool. Will release it during the coming week.

@veelenga veelenga added this to the 1.4.2 milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants