Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spec/ameba/formatter/json_formatter_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -26,31 +26,31 @@ module Ameba
context "sources" do
it "shows path to the source" do
result = get_result [Source.new "", "source.cr"]
result["sources"].first["path"].should eq "source.cr"
result["sources"][0]["path"].should eq "source.cr"
end

it "shows rule name" do
s = Source.new ""
s.error DummyRule.new, 1, 2, "message1"

result = get_result [s]
result["sources"].first["errors"].first["rule_name"].should eq DummyRule.name
result["sources"][0]["errors"][0]["rule_name"].should eq DummyRule.name
end

it "shows a message" do
s = Source.new ""
s.error DummyRule.new, 1, 2, "message"

result = get_result [s]
result["sources"].first["errors"].first["message"].should eq "message"
result["sources"][0]["errors"][0]["message"].should eq "message"
end

it "shows error location" do
s = Source.new ""
s.error DummyRule.new, 1, 2, "message"

result = get_result [s]
location = result["sources"].first["errors"].first["location"]
location = result["sources"][0]["errors"][0]["location"]
location["line"].should eq 1
location["column"].should eq 2
end
Expand Down
2 changes: 1 addition & 1 deletion spec/ameba/runner_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ module Ameba
end

it "returns false if there are invalid sources" do
rules = Rule.rules.map &.new
rules = Rule.rules.map &.new.as(Rule::Base)
s = Source.new %q(
WrongConstant = 5
)
Expand Down
2 changes: 1 addition & 1 deletion src/ameba/config.cr
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class Ameba::Config
#
# `Config.load` uses this constructor to instantiate new config by YAML file.
protected def initialize(@config : YAML::Any)
@rules = Rule.rules.map &.new(config)
@rules = Rule.rules.map &.new(config).as(Rule::Base)

if @config.as_h? && (name = @config["Formatter"]?.try &.["Name"]?)
self.formatter = name.to_s
Expand Down