Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ubuntu container version and MUSL-related libs #452

Merged
merged 6 commits into from
Sep 4, 2020
Merged

Bump Ubuntu container version and MUSL-related libs #452

merged 6 commits into from
Sep 4, 2020

Conversation

brainstorm
Copy link
Contributor

@brainstorm brainstorm commented Aug 12, 2020

Several reasons, including but not limited to:

  1. MUSL-compiled OpenSSL benefits from MUSL versions 1.2.0 and up, otherwise it needs to be badly patched, see Unnecessarily dangerous -DOPENSSL_NO_SECURE_MEMORY fornwall/rust-static-builder#3 (comment).
  2. DWARFv2 compressed debugging symbols mess up with old toolchains and linkers, see MUSL compile fix for "unable to initialize decompress status for section .debug_info" rust-bio/rust-htslib#231.

@brainstorm brainstorm requested review from Dylan-DPC-zz and a team as code owners August 12, 2020 03:28
…for section .debug_info' is not happening here as well... bump from stretch to buster to see if mips errors vanish with newer release
@brainstorm
Copy link
Contributor Author

brainstorm commented Aug 12, 2020

Almost there, only one target failing! Weird since this target does have hard float, I think:

cc1: error: '-mfloat-abi=hard': selected processor lacks an FPU

https://dev.azure.com/rust-embedded/cross/_build/results?buildId=681&view=logs&j=a134d3ac-19f9-5b18-b9f9-e20a7ce298ca&t=d355af61-270d-5eea-cd8e-e7caee8e7120&l=139882

brainstorm added a commit to rust-bio/rust-htslib that referenced this pull request Aug 12, 2020
* Cleanup and bump rust-embedded cross base image from upstream in cross-rs/cross#452 to fix the debug symbols issue observed in #231

* Add test for non-release builds against all features (previously failing because of old toolchain)

* Clean all the libs that are already handled via -sys crates. zlib cloudflare must be fixed upstream, not here. Only LLVM is needed at this point via docker, the (broken) htslib Makefile to build.rs transition that @pmarks did, simplified all this significantly, kudos
@brainstorm
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 13, 2020

🔒 Permission denied

Existing reviewers: click here to make brainstorm a reviewer

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine (and needed), but I'm not sure about consequences.

@Emilgardis Emilgardis requested review from reitermarkus and a team August 13, 2020 10:17
@brainstorm
Copy link
Contributor Author

Thanks @Emilgardis 👍🏻

Does any of the reviewers fear that something is going to break or similar side effects? The changes are not so many IMHO :-S

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this.

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 4, 2020

Build succeeded:

@bors bors bot merged commit 699f07a into cross-rs:master Sep 4, 2020
@brainstorm brainstorm deleted the bump_musl branch September 8, 2020 06:01
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants