Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gcc/musl version for the musl images #432

Closed
anupdhml opened this issue Jun 4, 2020 · 2 comments
Closed

Upgrade gcc/musl version for the musl images #432

anupdhml opened this issue Jun 4, 2020 · 2 comments

Comments

@anupdhml
Copy link
Contributor

anupdhml commented Jun 4, 2020

The musl images currently come with gcc version 6.40 which fails to compile C/C++ dependencies for crates that require at least version 7 (eg: snmalloc-rs).

I see that there's a new release of musl-cross-make now (comes with gcc 9.2 and musl 1.2 by default) so can we start using it for musl installation in the cross images?


Looks like there was an attempt to do something similar earlier but was closed out then due to CI failures: #397

I have tried doing it from a fork locally (also bumped up the gcc/musl versions passed to the musl-cross-make setup) and the musl image builds from there seem to work fine. If it's ok to go ahead with these changes, I can file a PR for it.

@brainstorm
Copy link
Contributor

@anupdhml , as soon as maintainers merge #452, you should be good to go and close this issue ;)

@Alexhuszagh
Copy link
Contributor

The musl images currently use GCC v9.2.0, so this should be fixed.

cross/docker/musl.sh

Lines 49 to 56 in 459e03e

hide_output make install "-j$(nproc)" \
GCC_VER=9.2.0 \
MUSL_VER=1.2.0 \
BINUTILS_VER=2.33.1 \
DL_CMD='curl --retry 3 -sSfL -C - -o' \
LINUX_HEADERS_SITE=$linux_headers_site \
OUTPUT=/usr/local/ \
"${@}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants