-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUSL compile fix for "unable to initialize decompress status for section .debug_info" #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via a fork in FiloSottile/homebrew-musl-cross#13 (comment), so now it's fast to install (just a bottle pour) :)
…out debug symbols (-C debuginfo=2, being a shortcut for -g), release should not include that flag
Working (local) vs breaking (CI) compiler flags: Compiling hts-sys v1.10.3 (/project/hts-sys)
Running `rustc --crate-name build_script_build
--edition=2018 hts-sys/build.rs
--error-format=json
--json=diagnostic-rendered-ansi
--crate-type bin
--emit=dep-info,link -C opt-level=3
-Cembed-bitcode=no
--cfg 'feature="bindgen"'
--cfg 'feature="bzip2"'
--cfg 'feature="bzip2-sys"'
--cfg 'feature="curl"'
--cfg 'feature="curl-sys"'
--cfg 'feature="gcs"'
--cfg 'feature="libdeflate"'
--cfg 'feature="libdeflate-sys"'
--cfg 'feature="lzma"'
--cfg 'feature="lzma-sys"'
--cfg 'feature="openssl-sys"'
--cfg 'feature="s3"'
--cfg 'feature="static"'
-C metadata=4d7d1f1c1148d63a
-C extra-filename=-4d7d1f1c1148d63a
--out-dir /target/release/build/hts-sys-4d7d1f1c1148d63a
-L dependency=/target/release/deps
--extern bindgen=/target/release/deps/libbindgen-dc93578612926c83.rlib
--extern cc=/target/release/deps/libcc-3c174a2e98767068.rlib
--extern fs_utils=/target/release/deps/libfs_utils-00311afaf56c6971.rlib
--extern glob=/target/release/deps/libglob-5340b1c47da11be1.rlib
-L native=/target/release/build/libloading-18bf0097e9c1a49e/out`
Compiling hts-sys v1.10.3 (/project/hts-sys)
Running `rustc --crate-name build_script_build
--edition=2018 hts-sys/build.rs
--error-format=json
--json=diagnostic-rendered-ansi
--crate-type bin
--emit=dep-info,link
-Cembed-bitcode=no
-C debuginfo=2 <--------------- CULPRIT?
--cfg 'feature="bindgen"'
--cfg 'feature="bzip2"'
--cfg 'feature="bzip2-sys"'
--cfg 'feature="curl"'
--cfg 'feature="curl-sys"'
--cfg 'feature="gcs"'
--cfg 'feature="libdeflate"'
--cfg 'feature="libdeflate-sys"'
--cfg 'feature="lzma"'
--cfg 'feature="lzma-sys"'
--cfg 'feature="openssl-sys"'
--cfg 'feature="s3"'
--cfg 'feature="static"'
-C metadata=245f1f7e9ca62bb9
-C extra-filename=-245f1f7e9ca62bb9
--out-dir /target/debug/build/hts-sys-245f1f7e9ca62bb9
-C incremental=/target/debug/incremental
-L dependency=/target/debug/deps
--extern bindgen=/target/debug/deps/libbindgen-05d3837d6e6c7651.rlib
--extern cc=/target/debug/deps/libcc-97348af50fbbad9d.rlib
--extern fs_utils=/target/debug/deps/libfs_utils-534a41f21dc0c7a3.rlib
--extern glob=/target/debug/deps/libglob-268e6a55a2027c26.rlib
-L native=/target/debug/build/libloading-76090e1587b44adb/out` |
pmarks
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
This was referenced Aug 12, 2020
Merged
brainstorm
changed the title
Musl compile fix
MUSL compile fix for "unable to initialize decompress status for section .debug_info"
Aug 12, 2020
brainstorm
added a commit
that referenced
this pull request
Aug 12, 2020
* Cleanup and bump rust-embedded cross base image from upstream in cross-rs/cross#452 to fix the debug symbols issue observed in #231 * Add test for non-release builds against all features (previously failing because of old toolchain) * Clean all the libs that are already handled via -sys crates. zlib cloudflare must be fixed upstream, not here. Only LLVM is needed at this point via docker, the (broken) htslib Makefile to build.rs transition that @pmarks did, simplified all this significantly, kudos
bors bot
added a commit
to cross-rs/cross
that referenced
this pull request
Sep 3, 2020
452: Bump Ubuntu container version and MUSL-related libs r=therealprof a=brainstorm Several reasons, including but not limited to: 1) MUSL-compiled OpenSSL benefits from MUSL versions 1.2.0 and up, otherwise it needs to be badly patched, see fornwall/rust-static-builder#3 (comment). 2) DWARFv2 compressed debugging symbols mess up with old toolchains and linkers, see rust-bio/rust-htslib#231. Co-authored-by: Roman Valls Guimera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like recent changes on the underlying musl/gcc toolchains affecting DWARF trigger build failures for debug (non
--release
builds).For more context, the current rust-musl-make binutils version is 2.33.1, which apparently has compression for the debug symbols. see, i.e: TA-Lib/ta-lib-python#268 (comment)
I don't like to downgrade toolchain versions either, so I'll make the assumption that debug builds for MUSL are not very used ATM... my workflow is (re-)building and deploying AWS lambdas in
--release
mode for now.