-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themis CocoaPods now support CLOpenSSL-XCF #828
Themis CocoaPods now support CLOpenSSL-XCF #828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe cherry-picks should be out of this PR, so that when squash-merged it contains only changes related to XCF migration for CocoaPods.
I sometimes do cherry-picks with just git cherry-pick -x -S commits...
and push directly into target branch if the changes are not controversial and does not require conflict resolution. Otherwise a separate PR would be better, linking to original PRs.
Regarding GRKOpenSSL, I believe the CLOpenSSL support appear somewhere in 0.13.x release but was not a part of 0.13.0. There was also no deprecation notice for GRKOpenSSL, so I think it would not be nice to just drop it immediately. At the same time, 0.13.x branch can serve as a fallback. So even if it's not technically nice, and we should have planned it better, I think it would not be a major issue for users if we drop So it might be acceptable to issue a deprecation notice now, in 0.13.10, then drop it in 0.14.0. Those who still need old subspecs should continue using 0.13.10 or earlier, until they are ready to migrate to 0.14.x – which should be a matter of replacing While we're at it, maybe it's time to drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @julepka!
I suggest doing 2 PRs: updating Carthage examples first (merge first), supporting CCPs XCFrameworks (merge second).
- updating examples is a simple "grab from master" update
- adding XCF for CCP is a real hotfix change for 0.13.10, which should be a separate PR in case we need to revert it
This reverts commit d9403c5.
I agree. Let's deprecate 'themis-openssl' with GRKOpenSSL. I'm looking for the best option to give a notice about that. Poscpec syntax doesn't support subspec deprecation. I don't see a way to notify the user when running 'pod install' or 'pod update'. I think we can just make a notice in Changelog, Release Notes and in public docs.
I've just checked it and it seems that there is still some life in their repo. But yeah... its pod was not updated since 2018 I guess... I think we can deprecate it as well. |
BoringSSL repo is alive and kicking, of course. However, they don't seem to be maintaining the podspec anymore. It has been submitted by a person from Google, sure, but I guess they got their promotion and it ended with that 🤷
My tiny head can hold only so many acronyms. There are already two CCPs there (one from China and one from Iceland), and I doubt I can fit any more... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, let's finalise wording on deprecation and Changelog, make sure that Apple-related tests pass, and merge
CI machine can't find python |
* Carthage XCF support and OpenSSL 1.1.1k (#817) * Update Carthage examples to unbreak tests (#829) * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * fix changelog conflict * Themis CocoaPods now support CLOpenSSL-XCF (#828) * Updated podspec to support OpenSSL-XCF * versions update * update changelog * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * Revert "Fixing Carthage examples embed settings (#827)" This reverts commit d9403c5. * Revert "Cherry-pick: Updated Carthage examples to use XCF (#823)" This reverts commit 6c14677. * update changelog * added deprecation notice to podspec and changelog * update changelog
Release 0.13.10
Now CocoaPods will use CLOpenSSL-XCF that contains the latest version of OpenSSL 1.1.1k.
We no longer need a workaround for arm64 simulator for subspec with CLOpenSSL-XCF.
Cherry-picked latest Carthage examples to fix tests in this branch.
Example projects will be updated afterwards, so they can reference 0.13.10 podspec
Also, just FYI there are thoughts to drop GRKOpenSSLFramework support as there are no updates from them for a long time... It may be an item to consider for 0.14
Checklist
Example projects and code samples are up-to-date (in case of API changes)