-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Carthage examples embed settings #827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that the frameworks were not embedded before...
We have way too many examples to test them all manually.
Previously there were a workaround for Carthage to copy frameworks. Like, you do not embed but it copies with a script or something like that... And with XCF support they've removed the workaround but I forgot to embed the framework 😓 |
Truly so, the problem arise with testing examples on a real device / via TestFlight. We might want to add some extra step on archiving / uploading to TF, but we will still have a step to manually install on a real device. |
This reverts commit d9403c5.
* Updated podspec to support OpenSSL-XCF * versions update * update changelog * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * Revert "Fixing Carthage examples embed settings (#827)" This reverts commit d9403c5. * Revert "Cherry-pick: Updated Carthage examples to use XCF (#823)" This reverts commit 6c14677. * update changelog * added deprecation notice to podspec and changelog * update changelog
* Carthage XCF support and OpenSSL 1.1.1k (#817) * Update Carthage examples to unbreak tests (#829) * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * fix changelog conflict * Themis CocoaPods now support CLOpenSSL-XCF (#828) * Updated podspec to support OpenSSL-XCF * versions update * update changelog * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * Revert "Fixing Carthage examples embed settings (#827)" This reverts commit d9403c5. * Revert "Cherry-pick: Updated Carthage examples to use XCF (#823)" This reverts commit 6c14677. * update changelog * added deprecation notice to podspec and changelog * update changelog
Do not embed
toEmbed and sign
option for Carthage iOS for Swift and Objective-CHello
label when app is runningChecklist
Changelog is updated (in case of notable or breaking changes)- No new features added