Fixing Carthage examples embed settings #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
approved these changes
May 24, 2021
ilammy
approved these changes
May 24, 2021
julepka
added
M-Carthage
Previously there were a workaround for Carthage to copy frameworks. Like, you do not embed but it copies with a script or something like that... And with XCF support they've removed the workaround but I forgot to embed the framework 😓 |
Truly so, the problem arise with testing examples on a real device / via TestFlight. We might want to add some extra step on archiving / uploading to TF, but we will still have a step to manually install on a real device. |
julepka
added a commit
to julepka/themis
that referenced
this pull request
May 26, 2021
julepka
added a commit
to julepka/themis
that referenced
this pull request
May 26, 2021
julepka
added a commit
to julepka/themis
that referenced
this pull request
May 26, 2021
This reverts commit d9403c5.
vixentael
pushed a commit
that referenced
this pull request
May 26, 2021
vixentael
pushed a commit
that referenced
this pull request
May 26, 2021
* Updated podspec to support OpenSSL-XCF * versions update * update changelog * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * Revert "Fixing Carthage examples embed settings (#827)" This reverts commit d9403c5. * Revert "Cherry-pick: Updated Carthage examples to use XCF (#823)" This reverts commit 6c14677. * update changelog * added deprecation notice to podspec and changelog * update changelog
julepka
added a commit
that referenced
this pull request
May 27, 2021
* Carthage XCF support and OpenSSL 1.1.1k (#817) * Update Carthage examples to unbreak tests (#829) * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * fix changelog conflict * Themis CocoaPods now support CLOpenSSL-XCF (#828) * Updated podspec to support OpenSSL-XCF * versions update * update changelog * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * Revert "Fixing Carthage examples embed settings (#827)" This reverts commit d9403c5. * Revert "Cherry-pick: Updated Carthage examples to use XCF (#823)" This reverts commit 6c14677. * update changelog * added deprecation notice to podspec and changelog * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not embedtoEmbed and signoption for Carthage iOS for Swift and Objective-CHellolabel when app is runningChecklist
Changelog is updated (in case of notable or breaking changes)- No new features added