Updated Carthage examples to use XCF #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julepka
added
M-Carthage
ilammy
approved these changes
May 15, 2021
Co-authored-by: Alexei Lozovsky <[email protected]>
vixentael
approved these changes
May 16, 2021
I suggest merge it, and then in a week, tweak Bitrise tests |
julepka
added a commit
to julepka/themis
that referenced
this pull request
May 26, 2021
julepka
added a commit
to julepka/themis
that referenced
this pull request
May 26, 2021
vixentael
pushed a commit
that referenced
this pull request
May 26, 2021
vixentael
pushed a commit
that referenced
this pull request
May 26, 2021
* Updated podspec to support OpenSSL-XCF * versions update * update changelog * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * Revert "Fixing Carthage examples embed settings (#827)" This reverts commit d9403c5. * Revert "Cherry-pick: Updated Carthage examples to use XCF (#823)" This reverts commit 6c14677. * update changelog * added deprecation notice to podspec and changelog * update changelog
julepka
added a commit
that referenced
this pull request
May 27, 2021
* Carthage XCF support and OpenSSL 1.1.1k (#817) * Update Carthage examples to unbreak tests (#829) * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * fix changelog conflict * Themis CocoaPods now support CLOpenSSL-XCF (#828) * Updated podspec to support OpenSSL-XCF * versions update * update changelog * Cherry-pick: Updated Carthage examples to use XCF (#823) * Fixing Carthage examples embed settings (#827) * Revert "Fixing Carthage examples embed settings (#827)" This reverts commit d9403c5. * Revert "Cherry-pick: Updated Carthage examples to use XCF (#823)" This reverts commit 6c14677. * update changelog * added deprecation notice to podspec and changelog * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Carthage examples:
themis.xcframework--use-xcframeworksflagNote: Bitrise doesn't support the required Carthage version 0.38 to build XCF properly. They are going to update to 0.38 about in a week: https://discuss.bitrise.io/t/how-to-upgrade-carthage-to-version-0-38-0/16796. If we are not in hurry, this PR can wait for the Bitrise update.
Checklist