Pin emsdk to avoid regression#663
Merged
ilammy merged 1 commit intocossacklabs:masterfrom Jul 7, 2020
Merged
Conversation
The current HEAD of emsdk repository includes a change that causes the
builds to fail with an error:
Adding directories to PATH:
PATH += /home/user/emsdk
PATH += /home/user/emsdk/fastcomp/emscripten
PATH += /home/user/emsdk/node/12.18.1_64bit/bin
Setting environment variables:
EMSDK = /home/user/emsdk
EM_CONFIG = /home/user/emsdk/.emscripten
EM_CACHE = /home/user/emsdk/fastcomp/emscripten/cache
EMSDK_NODE = /home/user/emsdk/node/12.18.1_64bit/bin/node
/home/user/emsdk/emsdk_env.sh: line 26: /home/user/emsdk/emsdk_set_env.sh: No such file or directory
The change [1] has optimized environment variable setup. Apparently,
it has issues. To avoid breaking our builds, roll back to the previous
known good state for the time being. The issue has been reported to
Emscripten [2], but it's not clear when it's going to be reverted and
fixed, so we'd rather not depend on that right now, when Themis release
is brewing.
[1]: emscripten-core/emsdk#539
[2]: emscripten-core/emsdk#540
ilammy
added
infrastructure
shadinua
approved these changes
Jul 7, 2020
vixentael
approved these changes
Jul 7, 2020
| cd $HOME/emsdk | ||
| git reset --hard | ||
| git pull | ||
| # FIXME(ilammy, 2020-07-07): unpin emsdk version [T1698] |
Contributor
There was a problem hiding this comment.
amount of FIXME tags for emsdk is sad :(
Collaborator
Author
There was a problem hiding this comment.
Expect a new one on August 7 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current HEAD of emsdk repository includes a change that causes the builds to fail with an error:
The change has optimized environment variable setup. Apparently, it has issues. To avoid breaking our builds, roll back to the previous known good state for the time being. The issue has been reported to Emscripten, but it's not clear when it's going to be reverted and fixed, so we'd rather not depend on that right now, when Themis release is brewing.
@shadinua, this change needs to be applied to Buildbot infra as well. It's currently broken all over the place because of that.
Checklist