Cleanup emsdk_env scripts #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the optional argument to contruct_env. It simple if we always construct the env in the same place. Avoid using temp files, and avoid changing directory.
tlively
approved these changes
Jul 6, 2020
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Looks like some nice simplifications to me. Do we have any testing to guarantee that all the more esoteric shell scripts still work?
Collaborator
Author
|
No tests for this stuff no :( Of course it would be nice if we had some... but I'm not signing up to do that today :) |
ilammy
added a commit
to ilammy/themis
that referenced
this pull request
Jul 7, 2020
The current HEAD of emsdk repository includes a change that causes the
builds to fail with an error:
Adding directories to PATH:
PATH += /home/user/emsdk
PATH += /home/user/emsdk/fastcomp/emscripten
PATH += /home/user/emsdk/node/12.18.1_64bit/bin
Setting environment variables:
EMSDK = /home/user/emsdk
EM_CONFIG = /home/user/emsdk/.emscripten
EM_CACHE = /home/user/emsdk/fastcomp/emscripten/cache
EMSDK_NODE = /home/user/emsdk/node/12.18.1_64bit/bin/node
/home/user/emsdk/emsdk_env.sh: line 26: /home/user/emsdk/emsdk_set_env.sh: No such file or directory
The change [1] has optimized environment variable setup. Apparently,
it has issues. To avoid breaking our builds, roll back to the previous
known good state for the time being. The issue has been reported to
Emscripten [2], but it's not clear when it's going to be reverted and
fixed, so we'd rather not depend on that right now, when Themis release
is brewing.
[1]: emscripten-core/emsdk#539
[2]: emscripten-core/emsdk#540
2 tasks
ilammy
added a commit
to cossacklabs/themis
that referenced
this pull request
Jul 7, 2020
The current HEAD of emsdk repository includes a change that causes the
builds to fail with an error:
Adding directories to PATH:
PATH += /home/user/emsdk
PATH += /home/user/emsdk/fastcomp/emscripten
PATH += /home/user/emsdk/node/12.18.1_64bit/bin
Setting environment variables:
EMSDK = /home/user/emsdk
EM_CONFIG = /home/user/emsdk/.emscripten
EM_CACHE = /home/user/emsdk/fastcomp/emscripten/cache
EMSDK_NODE = /home/user/emsdk/node/12.18.1_64bit/bin/node
/home/user/emsdk/emsdk_env.sh: line 26: /home/user/emsdk/emsdk_set_env.sh: No such file or directory
The change [1] has optimized environment variable setup. Apparently,
it has issues. To avoid breaking our builds, roll back to the previous
known good state for the time being. The issue has been reported to
Emscripten [2], but it's not clear when it's going to be reverted and
fixed, so we'd rather not depend on that right now, when Themis release
is brewing.
[1]: emscripten-core/emsdk#539
[2]: emscripten-core/emsdk#540
|
Today when I started my environment, I got this error when sourcing |
|
I have the same problem; this happens when emsdk_env.sh is sourced from a folder that's not emsdk (e.g. |
Member
|
Sorry about this, I think it's fixed by #541 which I am landing right now. |
Contributor
|
The optional argument was added to fix this: |
Collaborator
Author
|
Oops, sorry about that. I'll take a look. |
Collaborator
Author
|
At I see the problem. I will see if we can swich to using stdout instead (a la |
sbc100
added a commit
that referenced
this pull request
Jul 9, 2020
This is an alternative fix for emscripten-core/emscripten#9090 which recently came up again after #539. Tested with bash, tcsh and fish.
sbc100
added a commit
that referenced
this pull request
Jul 9, 2020
This is an alternative fix for emscripten-core/emscripten#9090 which recently came up again after #539. Tested with bash, tcsh and fish.
sbc100
added a commit
that referenced
this pull request
Jul 11, 2020
This is an alternative fix for emscripten-core/emscripten#9090 which recently came up again after #539. Tested with bash, tcsh and fish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the optional argument to contruct_env. It simple if we
always construct the env in the same place. Avoid using temp files,
and avoid changing directory.