Skip to content

Pin emsdk to avoid regression #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilammy merged 1 commit into from
Jul 7, 2020
Merged

Pin emsdk to avoid regression #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,9 @@ jobs:
cd $HOME/emsdk
git reset --hard
git pull
# FIXME(ilammy, 2020-07-07): unpin emsdk version [T1698]
Copy link
Contributor

@vixentael vixentael Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amount of FIXME tags for emsdk is sad :(

Copy link
Collaborator Author

@ilammy ilammy Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expect a new one on August 7 😂

Copy link
Contributor

@vixentael vixentael Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

# Latest HEAD has a regression, we roll back to last good version.
git checkout 92d512faa832b3ff5d6b8bc991b6801e31d8e372
# FIXME(ilammy, 2020-06-07): migrate to "upstream" flavor
# LLVM flavor of Emscripten has some issues compiling our code,
# and latest versions of the fastcomp flavor started giving out
Expand Down Expand Up @@ -629,6 +632,9 @@ jobs:
cd $HOME/emsdk
git reset --hard
git pull
# FIXME(ilammy, 2020-07-07): unpin emsdk version [T1698]
# Latest HEAD has a regression, we roll back to last good version.
git checkout 92d512faa832b3ff5d6b8bc991b6801e31d8e372
# FIXME(ilammy, 2020-06-07): migrate to "upstream" flavor
# LLVM flavor of Emscripten has some issues compiling our code,
# and latest versions of the fastcomp flavor started giving out
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ jobs:
cd $HOME
git clone https://github.com/emscripten-core/emsdk.git
cd $HOME/emsdk
# FIXME(ilammy, 2020-07-07): unpin emsdk version [T1698]
# Latest HEAD has a regression, we roll back to last good version.
git checkout 92d512faa832b3ff5d6b8bc991b6801e31d8e372
# FIXME(ilammy, 2020-06-07): migrate to "upstream" flavor
# LLVM flavor of Emscripten has some issues compiling our code,
# and latest versions of the fastcomp flavor started giving out
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-wasm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ jobs:
cd $HOME
git clone https://github.com/emscripten-core/emsdk.git
cd $HOME/emsdk
# FIXME(ilammy, 2020-07-07): unpin emsdk version [T1698]
# Latest HEAD has a regression, we roll back to last good version.
git checkout 92d512faa832b3ff5d6b8bc991b6801e31d8e372
# FIXME(ilammy, 2020-06-07): migrate to "upstream" flavor
# LLVM flavor of Emscripten has some issues compiling our code,
# and latest versions of the fastcomp flavor started giving out
Expand Down