gRPC gateway init #7019

atheeshp · 2020-08-12T10:22:34Z

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

…21-grpc-gateway-register

codecov · 2020-08-14T11:14:13Z

Codecov Report

Merging #7019 into master will decrease coverage by 0.28%.
The diff coverage is 4.76%.

@@            Coverage Diff             @@
##           master    #7019      +/-   ##
==========================================
- Coverage   54.82%   54.53%   -0.29%     
==========================================
  Files         561      566       +5     
  Lines       38327    38728     +401     
==========================================
+ Hits        21012    21120     +108     
- Misses      15604    15884     +280     
- Partials     1711     1724      +13

…21-grpc-gateway-register

…s/cosmos-sdk into atheesh/5921-grpc-gateway-register

…21-grpc-gateway-register

anilcse · 2020-08-24T21:40:56Z

Thanks! Excited about this PR! Are the grpc routes going to be registered in a follow-up PR?

Thanks for a quick review @fedekunze . I've addressed all your comments. Yes, I will create a follow-up PR for integrating all other modules.

x/capability/module.go

amaury1093

Also excited about this PR, thanks @anilcse and @atheeshp!

server/api/server.go

x/bank/client/rest/grpc_query_test.go

types/rest/rest.go

x/bank/client/rest/grpc_query_test.go

amaury1093

The PR lgtm!

Added question about how the staking validators HTTP route should look like

amaury1093 · 2020-08-25T15:41:23Z

x/staking/client/rest/grpc_query_test.go

+			true,
+		},
+		{
+			"test query validators gRPC route without status query param",


Hmm, if the status query param is required, would it make more sense to have the route as /cosmos/staking/v1beta1/validators/{status}?

Yes I also agree that requiring query parameters seems strange. Is this a pattern we follow elsewhere? Would be nice to not have it at all as a pattern.

That will conflict with other route: /cosmos/staking/v1beta1/validators/{validator_id}. I also spent some time to update this in annotations PR but ended up here. Old REST querier is also using it in the same way. May be we can add a default status for this. By default we can fetch all the bonded validators, wdyt?

Having a default status sounds better than erroring out no a REST call without query parameters IMO.

amaury1093 · 2020-08-25T15:45:49Z

ah, forgot about automerge. My question #7019 (comment) is still relevant

* WIP: grpc server setup * add register grpc routes * updated go mod * updated grpc for all modules * added pb file for grpc gateway * udpated gw file * added a test for grpc route * fixed conflicts * added grpc server * grpc tests added * cleanup * Fix gateway forward issue * Add godoc * updated tests * fix lint * fix tests * fix tests * fix tests * fixed test * Add grpc headers * Fix error handling * Fix tests - hacky * Fix lint * remove debug logs * Fix review comments * move grpc tests into a separate file * Fix protobuf version * Update x/capability/module.go * Fix godoc * Fix review suggestions * Fix codec * Add query params test for gateway request * Fix gofmt Co-authored-by: anilCSE <[email protected]> Co-authored-by: Federico Kunze <[email protected]>

atheeshp added 13 commits August 10, 2020 13:59

WIP: grpc server setup

204f43a

add register grpc routes

fdaac0b

updated go mod

d5fadc9

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

83b38a6

…21-grpc-gateway-register

updated grpc for all modules

9d23a1f

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

e8ca8ea

…21-grpc-gateway-register

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

c443a46

…21-grpc-gateway-register

added pb file for grpc gateway

f51b946

udpated gw file

4de3b1c

added a test for grpc route

138b84b

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

1c7cd87

…21-grpc-gateway-register

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

1dec763

…21-grpc-gateway-register

fixed conflicts

351a2c1

atheeshp and others added 10 commits August 14, 2020 17:18

added grpc server

5c5c9f9

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

0031fa4

…21-grpc-gateway-register

grpc tests added

0868234

cleanup

a9d95c0

Fix gateway forward issue

1e078e6

Add godoc

84555f3

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

2f428cf

…21-grpc-gateway-register

Merge branch 'atheesh/5921-grpc-gateway-register' of github.com:cosmo…

5634896

…s/cosmos-sdk into atheesh/5921-grpc-gateway-register

updated tests

dd1a560

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

d92579a

…21-grpc-gateway-register

atheeshp changed the title ~~Adds grpc gateway register~~ gRPC gateway init Aug 20, 2020

atheeshp added 5 commits August 20, 2020 18:16

fix lint

308a5ed

fix tests

da96310

fix tests

5cf179b

fix tests

07c6fa6

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…

d2ed9ca

…21-grpc-gateway-register

Fix protobuf version

0d2e016

anilcse requested a review from fedekunze August 24, 2020 21:41

aaronc mentioned this pull request Aug 24, 2020

Query Protobuf Migration #5921

Closed

43 tasks

clevinson mentioned this pull request Aug 24, 2020

Tracking Issue: Stargate Release Candidate #7152

Closed

25 tasks

fedekunze approved these changes Aug 25, 2020

View reviewed changes

x/capability/module.go Outdated Show resolved Hide resolved

fedekunze and others added 3 commits August 25, 2020 10:38

Update x/capability/module.go

3b5d0f2

Merge branch 'master' into atheesh/5921-grpc-gateway-register

e174052

Fix godoc

736ec4c

fedekunze added A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. labels Aug 25, 2020

amaury1093 suggested changes Aug 25, 2020

View reviewed changes

anilcse added 4 commits August 25, 2020 19:57

Fix review suggestions

a49a749

Fix codec

03baa6b

Add query params test for gateway request

5f3eb57

Fix gofmt

1675dfa

anilcse requested a review from amaury1093 August 25, 2020 15:34

Merge branch 'master' into atheesh/5921-grpc-gateway-register

04e5e29

amaury1093 approved these changes Aug 25, 2020

View reviewed changes

mergify bot merged commit 78194e1 into master Aug 25, 2020

mergify bot deleted the atheesh/5921-grpc-gateway-register branch August 25, 2020 15:44

anilcse mentioned this pull request Aug 25, 2020

Fix GetValidators status param #7167

Merged

9 tasks

This was referenced Aug 26, 2020

Register gRPC Gateway routes #7173

Merged

Adds grpc tests for x/staking #7204

Merged

mdaleem mentioned this pull request Sep 1, 2020

Register x/mint gRPC gateway routes #7214

Merged

9 tasks

This was referenced Sep 1, 2020

Registers grpc routes for x/gov #7216

Merged

Register grpc routes for x/{slashing, params} #7223

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gRPC gateway init #7019

gRPC gateway init #7019

atheeshp commented Aug 12, 2020

codecov bot commented Aug 14, 2020 •

edited

Loading

anilcse commented Aug 24, 2020

amaury1093 left a comment

amaury1093 left a comment

amaury1093 Aug 25, 2020

clevinson Aug 25, 2020

anilcse Aug 25, 2020

clevinson Aug 25, 2020

amaury1093 commented Aug 25, 2020

gRPC gateway init #7019

gRPC gateway init #7019

Conversation

atheeshp commented Aug 12, 2020

Description

codecov bot commented Aug 14, 2020 • edited Loading

Codecov Report

anilcse commented Aug 24, 2020

amaury1093 left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

amaury1093 Aug 25, 2020

Choose a reason for hiding this comment

clevinson Aug 25, 2020

Choose a reason for hiding this comment

anilcse Aug 25, 2020

Choose a reason for hiding this comment

clevinson Aug 25, 2020

Choose a reason for hiding this comment

amaury1093 commented Aug 25, 2020

codecov bot commented Aug 14, 2020 •

edited

Loading