Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetValidators status param #7167

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Fix GetValidators status param #7167

merged 3 commits into from
Aug 26, 2020

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Aug 25, 2020

Description

QueryValidators require status filter for gRPC queries and is a mandatory param. It's bit odd UX. As discussed with @amaurymartiny and @clevinson , changing status query param to optional and returning all the validators when there's no status supplied, seems to be a better solution. This PR addresses the same.

ref: #7019 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7167 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7167      +/-   ##
==========================================
- Coverage   54.53%   54.53%   -0.01%     
==========================================
  Files         566      566              
  Lines       38729    38727       -2     
==========================================
- Hits        21121    21119       -2     
  Misses      15884    15884              
  Partials     1724     1724              

@anilcse anilcse changed the title Fix status filter Fix GetValidators status param Aug 25, 2020
@clevinson
Copy link
Contributor

lgtm. Thanks @anilcse !

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 26, 2020
@mergify mergify bot merged commit b5bc864 into master Aug 26, 2020
@mergify mergify bot deleted the anil/fix_grpc_annotations branch August 26, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants