Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds grpc tests for x/staking #7204

Merged
merged 13 commits into from
Sep 4, 2020
Merged

Conversation

atheeshp
Copy link
Contributor

ref: #5921
follow-up: #7019

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@atheeshp atheeshp changed the title Adds staking grpc tests Adds grpc tests for x/staking Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #7204 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7204   +/-   ##
=======================================
  Coverage   54.77%   54.77%           
=======================================
  Files         565      565           
  Lines       39138    39138           
=======================================
  Hits        21436    21436           
  Misses      15933    15933           
  Partials     1769     1769           

@aaronc aaronc mentioned this pull request Sep 1, 2020
43 tasks
@atheeshp atheeshp marked this pull request as ready for review September 3, 2020 11:18
x/staking/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
x/staking/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
x/staking/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
x/staking/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 4, 2020
@mergify mergify bot merged commit e9a0e82 into master Sep 4, 2020
@mergify mergify bot deleted the atheesh/5921-staking-grpc-tests branch September 4, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants