This repository was archived by the owner on Feb 5, 2020. It is now read-only.
tests: Report specific smoke test status to GitHub#2082
Merged
mxinden merged 6 commits intocoreos:masterfrom Nov 1, 2017
Merged
tests: Report specific smoke test status to GitHub#2082mxinden merged 6 commits intocoreos:masterfrom
mxinden merged 6 commits intocoreos:masterfrom
Conversation
mxinden
force-pushed
the
report-status-github
branch
11 times, most recently
from
1f0527d to
37037ff
Compare
mxinden
changed the title
Contributor
Author
|
@cpanato Could you review this? |
mxinden
force-pushed
the
report-status-github
branch
from
37037ff to
d3e1166
Compare
cpanato
previously approved these changes
Oct 16, 2017
Contributor
|
retest this please |
mxinden
force-pushed
the
report-status-github
branch
2 times, most recently
from
6c50bcd to
93536e6
Compare
Contributor
|
@mxinden when you click in the |
mxinden
force-pushed
the
report-status-github
branch
2 times, most recently
from
1ebf015 to
af46844
Compare
Contributor
Author
|
@sym3tri In the status field of this PR you can see the detailed Jenkins status feedback. Does this look good to you? |
mxinden
force-pushed
the
report-status-github
branch
5 times, most recently
from
e47459d to
50b31d0
Compare
Contributor
Author
Instead of reporting overall status to Github, this patch introduces more detailed status reports: 1. `basic-tests` includes all basic tests in the first stage of our pipeline. This status will be required to be green. In case it is red, a merge of the PR is disabled. 2. `gui-tests` represents the result of the GUI tests stage. It is not mendatory for merge. It will only run when the `run-gui-tests` label is set. 3. `smoke-tests/<test-name>` is going to be reported per smoke test. None of these status reports are mandatory for merge. These tests are only run when the `run-smoke-tests` label is set. 4. `continuous-integration/jenkins/pr-merge` is the overall status of the entire pipeline. This is not mandatory. I am looking into deactivating this in total, but haven't found a solution yet.
According to the Jenkins documentation `stash` should only be used for small amounts of data [1]. To prevent `java.io.IOException: Failed to extract repository.tar.gz` this patch reduces the stash scope to the npm_modules, the installer binary and the smoke test binary. The remaining repository files are loaded via standard git checkouts. [1] https://jenkins.io/doc/pipeline/steps/workflow-basic-steps/#code-stash-code-stash-some-files-to-be-used-later-in-the-build
mxinden
force-pushed
the
report-status-github
branch
from
50b31d0 to
8bd13bb
Compare
Contributor
|
retest this please |
cpanato
approved these changes
Oct 31, 2017
Contributor
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
LGTM. I just have one concern to do the checkout in all blocks.
Contributor
Author
|
@cpanato What is the concern? In case you are worried about the delay introduced by this change: The last test execution of this PR was 45 minutes. Last master execution was 48 minutes. |
Contributor
|
@mxinden more in terms of doing the checkout every time during the build. but this will be fixed when we implement the new builder :) |
This was referenced Nov 1, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.