This repository was archived by the owner on Feb 5, 2020. It is now read-only.
azure/vnet: Update Ingress LB name to <cluster>-tectonic-lb#2104
Merged
alexsomesan merged 1 commit intocoreos:masterfrom Dec 12, 2017
Merged
azure/vnet: Update Ingress LB name to <cluster>-tectonic-lb#2104alexsomesan merged 1 commit intocoreos:masterfrom
<cluster>-tectonic-lb#2104alexsomesan merged 1 commit intocoreos:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
Tests failed due to flake caused by SSH code (and fixed in #2093). Retrying |
Contributor
|
ok to test |
Contributor
|
setting labels to run azure tests |
Contributor
|
retest this please |
justaugustus
force-pushed
the
azure-lb-name
branch
from
ed221ac to
1b41c8f
Compare
Contributor
Author
|
@alexsomesan / @squat can you LGTM when you have a chance? |
Contributor
|
We did some changes (#2082) to the testing process. Please rebase on to current master, so that the |
justaugustus
force-pushed
the
azure-lb-name
branch
from
1b41c8f to
4ca1a2f
Compare
Contributor
Author
|
All set, @mxinden! |
Contributor
Author
|
@alexsomesan / @squat can we get this merged? |
alexsomesan
approved these changes
Dec 12, 2017
Contributor
|
done
…On Tue, Dec 12, 2017 at 5:32 AM, Stephen Augustus ***@***.***> wrote:
@alexsomesan <https://github.com/alexsomesan> / @squat
<https://github.com/squat> can we get this merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2104 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABC-m9TkbX5-MKXZCOEwcysQCn_fJTjPks5s_gHugaJpZM4P2ajh>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change to clarify the primary purpose for the load balancer in Azure i.e., to front Tectonic Console and Tectonic Identity.
Originally, the name of the load balancer was
${var.cluster_name}-api-lbwhich is misleading, especially in Azure private implementation instances (where the load balancer is not used to front the Kubernetes API).