Skip to content
This repository was archived by the owner on Feb 5, 2020. It is now read-only.

azure: make root_volume_size configurable for aws parity#2205

Closed
lamdor wants to merge 2 commits intocoreos:masterfrom
Banno:azure-add-root_volume_size
Closed

azure: make root_volume_size configurable for aws parity#2205
lamdor wants to merge 2 commits intocoreos:masterfrom
Banno:azure-add-root_volume_size

Conversation

@lamdor
Copy link
Contributor

@lamdor lamdor commented Oct 23, 2017

The OS image defaults to a 32GiB disk, however, it'd be nice to configure this so we can make it larger.

@justaugustus
Copy link
Contributor

@alexsomesan can you take a peep at this?
We've got a customer asking for this as well.

@mxinden
Copy link
Contributor

mxinden commented Nov 1, 2017

We did some changes (#2082) to the testing process. Please rebase on to current master, so that the basic-tests PR status is reported correctly.

@lamdor lamdor force-pushed the azure-add-root_volume_size branch from d2ea2de to 7f9f853 Compare November 1, 2017 13:09
@lamdor
Copy link
Contributor Author

lamdor commented Nov 1, 2017

@mxinden @justaugustus @alexsomesan Rebased.

@justaugustus
Copy link
Contributor

@rubbish would you mind rebasing this again and then running make structure-check?
You may also need to run terraform fmt . and make docs examples prior to pushing.

@lamdor lamdor force-pushed the azure-add-root_volume_size branch from 7f9f853 to 5064b0d Compare December 12, 2017 14:18
@lamdor
Copy link
Contributor Author

lamdor commented Dec 12, 2017

@justaugustus Done.

alexsomesan
alexsomesan previously approved these changes Dec 12, 2017
Copy link
Contributor

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cpanato
Copy link
Contributor

cpanato commented Feb 2, 2018

@rubbish can you please rebase? then I will run the tests. thanks!

@lamdor
Copy link
Contributor Author

lamdor commented Feb 2, 2018

@cpanato Done

@cpanato
Copy link
Contributor

cpanato commented Feb 2, 2018

ok to test

@cpanato
Copy link
Contributor

cpanato commented Feb 2, 2018

@rubbish can you please run 'make examples' to fix the issues?

outdated examples (run 'make examples' to fix)

Makefile:147: recipe for target 'structure-check' failed

@lamdor lamdor force-pushed the azure-add-root_volume_size branch from 831bc1a to 620a304 Compare February 2, 2018 20:34
@lamdor
Copy link
Contributor Author

lamdor commented Feb 2, 2018

@cpanato Updated the examples and rebased again.

@cpanato
Copy link
Contributor

cpanato commented Feb 5, 2018

@rubbish
some errors from the init phase:

Error getting plugins: 3 problems:


- module "etcd": missing required argument "root_volume_size"

- module "masters": missing required argument "root_volume_size"

- module "workers": missing required argument "root_volume_size"

make: *** [terraform-init] Error 1

@sym3tri
Copy link
Contributor

sym3tri commented Feb 19, 2018

Thanks for the contribution, but I'm going close this b/c it looks like the same functionality was just merged in #2944.

@sym3tri sym3tri closed this Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants