dracut: adapt for s/oem/platform in Ignition

[jlebon]

With coreos/ignition#735 merged, we need to fix
our service units to use --platform here. Also just do the equivalent
thing here and start to move away from the oem terminology. Crucially
though, we still look for coreos.oem.id until downstreams have
adapted (notably coreos-assembler).

[arithx]

LGTM

[ajeddeloh]

We're not building ignition rpms from master yet, so we ought to merge this to a different branch instead of master. I haven't gotten around to setting up a copr for the 3.0.0 work yet, but that seems like what we ought to do while we develop 3.0.0.

[jlebon]

We're not building ignition rpms from master yet, so we ought to merge this to a different branch instead of master.

Wouldn't it be cleaner to just match the Ignition repo and use a spec2x branch here too?

[ajeddeloh]

Yeah that's probably better. Since the RPM spec file refers to it by commit that should be fine.

[ajeddeloh]

But we should create that branch and add notes to the readmes before merging this

[jlebon]

OK, in favour of splitting. Though for this patch, I'd rather we maintain compatiblity for coreos.oem.id regardless until we can fully abandon the spec2x branches, and permanently move coreos-assembler to coreos.platform.id.

[jlebon]

and permanently move coreos-assembler to coreos.platform.id

Actually, we can take this opportunity to fix #31 as well and have the new name be e.g. ignition.platform.id.

Though we'll want to be careful with other consumers as @lucab mentioned.

[dustymabe]

this LGTM - re: spec2x I'd honestly rather just keep a single branch here and move to 3.0 spec sooner than later. For RHCOS maybe we could just backport patches in the rpm?

[dustymabe]

For RHCOS maybe we could just backport patches in the rpm?

only for ones that are absolutely required, of course

[jlebon]

OK, this is tested now, both using the old and the new kernel args. Dropping WIP, though let's see what people think re. ignition.platform.id.

[dustymabe]

though let's see what people think re. ignition.platform.id.

+1 for ignition.platform.id

[dustymabe]

this LGTM - re: spec2x I'd honestly rather just keep a single branch here and move to 3.0 spec sooner than later. For RHCOS maybe we could just backport patches in the rpm?

discussed in IRC. We'll go with this for now:

ignition{,-dracut} - master -> Fedora rpms
ignition{,-dracut} - spec2x -> EL7 rpms

[dustymabe]

FYI: created the spec2x branch: https://github.com/coreos/ignition-dracut/tree/spec2x

[bgilbert]

ignition.platform.id makes sense in the context of this repo, which is intended to be distro-independent. But for FCOS, at least, we'll be configuring a number of other distro behaviors (whether to start a platform agent, etc.) on the "Ignition" platform ID. That might make the name confusing. I don't have a better suggestion, though.

[bgilbert]

This breaks the oem_id logic in the previous stanza.

[jlebon]

Good catch! Added a fix for this in #46.