util/cmdline: rename "OEM ID" to "Platform ID"

[lucab]

This switches from "coreos.oem.id" to "ignition.platform.id" in
non-legacy mode.

Ref: coreos/coreos-assembler#428

[lucab]

/cc @bgilbert @dustymabe @cgwalters

[dustymabe]

This switches from "coreos.oem.id" to "coreos.platform.id"

shouldn't it be ignition.platform.id ? ref: coreos/ignition-dracut#45

[lucab]

@dustymabe indeed, I didn't see that PR. Renamed.

[bgilbert]

Per coreos/coreos-assembler#433 (comment), maybe we should go ahead and accept only the new flag in non-legacy mode.

[dustymabe]

Per coreos/coreos-assembler#433 (comment), maybe we should go ahead and accept only the new flag in non-legacy mode.

That makes sense. IOW the media creator will generate both coreos.oem.id and ignition.platform.id so the consumer software doesn't have to handle both cases.

[jlebon]

LGTM!

No strong opinion on whether we should handle both here too or not. Not handling both just means that we'll have to be sure that the RHCOS pipeline has coreos/coreos-assembler#433 backported before the next cut.

[lucab]

I'm going to hold this a bit until we sort out the approach in coreos/coreos-assembler#433. I'm fine either ways, I thought that an overlap window here would make easier the lockstep transition on RHCOS side.

[lucab]

coreos/coreos-assembler#433 landed adding both flags. As requested by @bgilbert, I reworked this PR to drop the overlapping/legacy fallback. PTAL, thanks!

[jlebon]

This looks good to me!

[bgilbert]

LGTM