Merged
Conversation
arithx
force-pushed
the
drop_oem_wording
branch
from
818d25e to
bfdb80a
Compare
ajeddeloh
approved these changes
Feb 23, 2019
Contributor
ajeddeloh
left a comment
ajeddeloh
left a comment
There was a problem hiding this comment.
LGTM assuming grep -i oem doesn't show anything else that should be removed
arithx
force-pushed
the
drop_oem_wording
branch
from
bfdb80a to
077a773
Compare
Switches from using the OEM terminology (a remnant of ChromiumOS) to platform. Fixes coreos#684
arithx
force-pushed
the
drop_oem_wording
branch
from
077a773 to
3de6446
Compare
Contributor
Author
|
Rebased, merging once green (only mentions of |
jlebon
added a commit
to jlebon/ignition-dracut
that referenced
this pull request
Feb 26, 2019
With coreos/ignition#735 merged, we need to fix our service units to use `--platform` here. Also just do the equivalent thing here and start to move away from the oem terminology. Crucially though, we still look for `coreos.oem.id` until other places adapt as well (notably coreos-assembler).
jlebon
added a commit
to jlebon/ignition-dracut
that referenced
this pull request
Feb 26, 2019
With coreos/ignition#735 merged, we need to fix our service units to use `--platform` here. Also just do the equivalent thing here and start to move away from the oem terminology. Crucially though, we still look for `coreos.oem.id` until downstreams have adapted (notably coreos-assembler).
Member
|
Follow-up to this in coreos/ignition-dracut#45. |
jlebon
added a commit
to jlebon/ignition-dracut
that referenced
this pull request
Feb 26, 2019
With coreos/ignition#735 merged, we need to fix our service units to use `--platform` here. Also just do the equivalent thing here and start to move away from the oem terminology. Crucially though, we still look for `coreos.oem.id` until downstreams have adapted (notably coreos-assembler).
jlebon
added a commit
to jlebon/ignition-dracut
that referenced
this pull request
Feb 26, 2019
With coreos/ignition#735 merged, we need to fix our service units to use `--platform` here. Also just do the equivalent thing here and start to move away from the oem terminology. Crucially though, we still look for `coreos.oem.id` until downstreams have adapted (notably coreos-assembler).
jlebon
added a commit
to jlebon/ignition-dracut
that referenced
this pull request
Feb 26, 2019
With coreos/ignition#735 merged, we need to fix our service units to use `--platform` here. Also just do the equivalent thing here and start to move away from the oem terminology. Crucially though, we still look for `coreos.oem.id` until downstreams have adapted (notably coreos-assembler). Closes: coreos#31
tormath1
pushed a commit
to tormath1/ignition
that referenced
this pull request
Jul 27, 2021
this flag has been renamed to `--platform` in coreos#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Aug 12, 2021
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Aug 12, 2021
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Aug 31, 2021
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Nov 10, 2021
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Jan 7, 2022
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Jan 31, 2022
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Feb 1, 2022
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar/ignition
that referenced
this pull request
Feb 24, 2022
this flag has been renamed to `--platform` in coreos/ignition#735. it's just a renaming (no logic has changed) but flatcar currently rely on ignition service files who use `--oem`. In the waiting of a full V2 deprecation, we will support both flags on Flatcar Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches from using the OEM terminology (a remnant of ChromiumOS) to
platform.
Fixes #684