Merged
Conversation
Member
Author
|
Requires: #228 Marking as draft, since I haven't tested this at all for now! |
dustymabe
approved these changes
May 1, 2020
Member
dustymabe
left a comment
dustymabe
left a comment
There was a problem hiding this comment.
LGTM - exciting things to come!
jlebon
force-pushed
the
pr/lockfile-bumper
branch
5 times, most recently
from
455039b to
b6cb4e7
Compare
This job will implement lockfile bumping for testing-devel and next-devel: coreos/fedora-coreos-tracker#293. The original plan for this functionality was to have it in config-bot: coreos/fedora-coreos-releng-automation#48 But in the end, I think it's more natural to have it as a Jenkins job given that it does a lot of the same things as the pipeline/upstream CI jobs. So that way it looks and feels just like another job that runs cosa, and we get kola artifacts, we can re-use the shared library, it's easily inspectable, we can hook it to Slack, etc...
Member
Author
|
OK, this is tested working now! I hit a subtle issue with lockfiles and shim-x64 which I need to follow-up with, though this PR is hacking around that for now. @dustymabe Want to take a final look before we merge this? |
This was referenced May 5, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This job will implement lockfile bumping for testing-devel and
next-devel: coreos/fedora-coreos-tracker#293.
The original plan for this functionality was to have it in config-bot:
coreos/fedora-coreos-releng-automation#48
But in the end, I think it's more natural to have it as a Jenkins job
given that it does a lot of the same things as the pipeline/upstream CI
jobs. So that way it looks and feels just like another job that runs
cosa, and we get kola artifacts, we can re-use the shared library,
it's easily inspectable, we can hook it to Slack, etc...