cmd-build: Stop using RUNVM_NONET=1 for now#1431
cmd-build: Stop using RUNVM_NONET=1 for now#1431jlebon wants to merge 1 commit intocoreos:masterfrom
Conversation
This is hitting into some subtle issues with cosa overrides and lockfiles. I'm working on an rpm-ostree patch to fix this, but for now, let's unblock all the upstream CIs which currently use RPM overrides.
|
Hmm...like |
arithx
left a comment
arithx
left a comment
There was a problem hiding this comment.
Makes sense to me.
/approve
| # --cache-only is here since `fetch` is a separate verb | ||
| # shellcheck disable=SC2086 | ||
| RUNVM_NONET=1 runcompose --cache-only ${FORCE} --add-metadata-from-json "${commitmeta_input_json}" \ | ||
| # XXX: use RUNVM_NONET=1 here once all issues are ironed out |
There was a problem hiding this comment.
Would be helpful to spell out the issues (or link to the rpm-ostree PR/issue that has more details).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arithx, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
OK right, let's do #1432 instead. /close Mind you, there is still something subtle going on here between our pkgcache and lockfiles when in relaxed mode, but #1432 should unblock CI at least. (Basically, we need to give preference to our cache when choosing between alternatives. Something like |
|
@jlebon: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This is hitting into some subtle issues with cosa overrides and
lockfiles. I'm working on an rpm-ostree patch to fix this, but for now,
let's unblock all the upstream CIs which currently use RPM overrides.