Merged
Conversation
This patch begins the transition from our current buildconfig-based pipeline jobs to the one used by CoreOS CI, which is CasC + job DSL + simple Groovy files in a `jobs/` dir + using the shared coreos-ci-lib library for making it easy to leverage OpenShift. I really like how it all fits together, and the upstream CI experimentation has seen some positive results. For now, we only install the seed job. This will allow us to then add pipeline jobs directly in `jobs/`. This is the same CasC fragment present in CoreOS CI: https://github.com/coreos/coreos-ci/blob/2421fabaef79f93d2c111fdf9bce648ab3d19680/jenkins/config/seed.yaml There's follow-ups there to make that seed job cleaner (and deduping from CoreOS CI).
Merged
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Aug 26, 2020
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: coreos#228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Aug 26, 2020
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: coreos#228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Aug 26, 2020
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: coreos#228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Aug 26, 2020
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: coreos#228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Sep 25, 2020
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: coreos#228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Oct 22, 2020
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: coreos#228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
jlebon
added a commit
that referenced
this pull request
Oct 22, 2020
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: #228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch begins the transition from our current buildconfig-based
pipeline jobs to the one used by CoreOS CI, which is CasC + job DSL +
simple Groovy files in a
jobs/dir + using the shared coreos-ci-liblibrary for making it easy to leverage OpenShift. I really like how it
all fits together, and the upstream CI experimentation has seen some
positive results.
For now, we only install the seed job. This will allow us to then
add pipeline jobs directly in
jobs/. This is the same CasC fragmentpresent in CoreOS CI:
https://github.com/coreos/coreos-ci/blob/2421fabaef79f93d2c111fdf9bce648ab3d19680/jenkins/config/seed.yaml
There's follow-ups there to make that seed job cleaner (and deduping
from CoreOS CI).