Convert kola test jobs to vanilla pipeline jobs#270
Conversation
|
Requires: coreos/coreos-ci-lib#36 |
jlebon
force-pushed
the
pr/tests-to-jobs
branch
from
176bec4 to
48e9ca0
Compare
|
(I'll admit I didn't test this. Since it's not the main pipeline itself, was thinking of just doing fixups as needed on top.) |
jlebon
force-pushed
the
pr/tests-to-jobs
branch
from
48e9ca0 to
c226e0c
Compare
|
Looks pretty straight-forward to me. 👍 |
jlebon
force-pushed
the
pr/tests-to-jobs
branch
from
c226e0c to
dff49da
Compare
|
Updated this now, but I'd like to sanity-check those |
| def AWS_FCOS_BUILDS_BOT_CONFIG = "/run/kubernetes/secrets/aws-fcos-builds-bot-config/config" | ||
| def AWS_FCOS_KOLA_BOT_CONFIG = "/run/kubernetes/secrets/aws-fcos-kola-bot-config/config" |
There was a problem hiding this comment.
hmm. That's not exactly what I had in mind. I think I'm bumping into a limitation in my knowledge on how things work.
I was thinking we'd be somehow re-using
fedora-coreos-pipeline/manifests/pod.yaml
Lines 23 to 24 in 35f1f18
rather than having to define it here again.
There was a problem hiding this comment.
We no longer use that pod definition in those jobs. Instead, we're telling cosaPod that we need access to the specific secrets (see coreos/coreos-ci-lib#37). That way, pods only get the secrets they need mounted in.
I guess an improvement we could make here is to expose the path to the secret in environment variables as part of that wrapper.
There was a problem hiding this comment.
E.g. in this file, notice:
cosaPod(image: params.COREOS_ASSEMBLER_IMAGE, memory: "256Mi",
secrets: ["aws-fcos-builds-bot-config", "aws-fcos-kola-bot-config"]) {There was a problem hiding this comment.
OK, sorry for the noise on this. I probably wouldn't have made the other comment if I had realized how it worked.
There was a problem hiding this comment.
No worries, I think a good idea came out of it regardless: coreos/coreos-ci-lib#39.
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I am not an expert in this pipeline, but the high level direction looks really good to me, and superficially code looks good too.
|
LGTM....any thing hold up the merge? |
|
Maybe let's hold just a day or two til we get the |
This is part of the push to move away from buildconfig-based jobs towards the same model as what upstream CI does. For more details, see: coreos#228 As a first victim, convert the kola tests since they're mostly straight-forward. A huge part of this is re-using coreos-ci-lib the same way upstream CI does. And this helps save us a lot of boilerplate (see diffstat for this patch). Converting to vanilla jobs also means we can now use the `build` step as intended, instead of hacking around it with `oc start-build`.
jlebon
force-pushed
the
pr/tests-to-jobs
branch
from
dff49da to
0cf12eb
Compare
|
OK, manually tested this locally now and fixed a bunch of issues. Also realized there's a gap in |
This was changed in coreos/fedora-coreos-pipeline#270.
This was changed in coreos/fedora-coreos-pipeline#270.
5 participants
This is part of the push to move away from buildconfig-based jobs
towards the same model as what upstream CI does. For more details, see:
#228
As a first victim, convert the kola tests since they're mostly
straight-forward. A huge part of this is re-using coreos-ci-lib the same
way upstream CI does. And this helps save us a lot of boilerplate (see
diffstat for this patch).
Converting to vanilla jobs also means we can now use the
buildstep asintended, instead of hacking around it with
oc start-build.