overrides: fasttrack ignition-2.2.1-5.git2d3ff58.fc31 #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
approved these changes
Apr 27, 2020
Member
Author
|
CI failed, but I don't understand why: |
Member
Author
|
The error is error is: This is because |
These have made it to bodhi stable now.
This gets us new networking improvements added in coreos/ignition-dracut#174.
dustymabe
force-pushed
the
dusty-new-ignition
branch
from
8bd5901 to
a7b21c3
Compare
Member
Author
|
rebased on top of latest master |
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Apr 27, 2020
By default, `cosa fetch` ignores overrides in `overrides/rpm` since those are meant to be temporary and might be e.g. locally built packages. (Otherwise, for example, removing a cosa override might cause `cosa build` to fail since the no longer overridden package was never actually downloaded). However, it can be useful sometimes to not ignore it if we know that it's not a "temporary" package and that it won't be found otherwise from the regular repos. This is the case in the CI of `fedora-coreos-config` where we use `overrides/rpm` to test composes with overrides without having to tag them into the pool first. Related: coreos/fedora-coreos-config#365 Closes: coreos#1117
Member
Author
|
with coreos/coreos-assembler#1404 |
openshift-merge-robot
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Apr 27, 2020
By default, `cosa fetch` ignores overrides in `overrides/rpm` since those are meant to be temporary and might be e.g. locally built packages. (Otherwise, for example, removing a cosa override might cause `cosa build` to fail since the no longer overridden package was never actually downloaded). However, it can be useful sometimes to not ignore it if we know that it's not a "temporary" package and that it won't be found otherwise from the regular repos. This is the case in the CI of `fedora-coreos-config` where we use `overrides/rpm` to test composes with overrides without having to tag them into the pool first. Related: coreos/fedora-coreos-config#365 Closes: #1117
Member
|
Do you want to try adding |
Member
Author
Does that mean we are no longer using |
Member
Author
|
ok |
jlebon
reviewed
Apr 27, 2020
.cci.jenkinsfile
Outdated
| """) | ||
|
|
||
| fcosBuild(skipInit: true) | ||
| fcosBuild(make: true, skipKola: true, extraFetchArgs: '--with-cosa-overrides') |
Member
There was a problem hiding this comment.
Hmm, why are we doing make: true and skipKola: true here and dropping skipInit: true? Was that by mistake?
Member
Author
There was a problem hiding this comment.
oops.. yeah. copy/paste error.
This was added in coreos/coreos-assembler#1404 extraFetchArgs was added to fcosBuild in coreos/coreos-ci-lib#26
dustymabe
force-pushed
the
dusty-new-ignition
branch
from
0bd5bd9 to
7e5800c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us new networking improvements added in coreos/ignition-dracut#174.