fcosBuild: add extraFetchArgs #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `extraArgs` but for `cosa fetch`. Sadly, building and testing software is complex and there's always going to be corner cases that burst through our nice and clean abstractions.
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Apr 27, 2020
This was added in coreos/coreos-assembler#1404 extraFetchArgs was added to fcosBuild in coreos/coreos-ci-lib#26
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Apr 27, 2020
This was added in coreos/coreos-assembler#1404 extraFetchArgs was added to fcosBuild in coreos/coreos-ci-lib#26
Member
|
Perhaps later split this up into |
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Apr 27, 2020
This was added in coreos/coreos-assembler#1404 extraFetchArgs was added to fcosBuild in coreos/coreos-ci-lib#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
extraArgsbut forcosa fetch. Sadly, building and testingsoftware is complex and there's always going to be corner cases that
burst through our nice and clean abstractions.