cmd-fetch: add --with-cosa-overrides #1404
Conversation
By default, `cosa fetch` ignores overrides in `overrides/rpm` since those are meant to be temporary and might be e.g. locally built packages. (Otherwise, for example, removing a cosa override might cause `cosa build` to fail since the no longer overridden package was never actually downloaded). However, it can be useful sometimes to not ignore it if we know that it's not a "temporary" package and that it won't be found otherwise from the regular repos. This is the case in the CI of `fedora-coreos-config` where we use `overrides/rpm` to test composes with overrides without having to tag them into the pool first. Related: coreos/fedora-coreos-config#365 Closes: coreos#1117
|
nit: Or was the hope to disambiguate between rpm files in |
Right, exactly. (I actually got confused myself when reading back my own comment at #1117 (comment) because "overrides" is already an overloaded word.) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was added in coreos/coreos-assembler#1404 extraFetchArgs was added to fcosBuild in coreos/coreos-ci-lib#26
This was added in coreos/coreos-assembler#1404 extraFetchArgs was added to fcosBuild in coreos/coreos-ci-lib#26
This was added in coreos/coreos-assembler#1404 extraFetchArgs was added to fcosBuild in coreos/coreos-ci-lib#26
4 participants
By default,
cosa fetchignores overrides inoverrides/rpmsincethose are meant to be temporary and might be e.g. locally built
packages. (Otherwise, for example, removing a cosa override might cause
cosa buildto fail since the no longer overridden package was neveractually downloaded).
However, it can be useful sometimes to not ignore it if we know that
it's not a "temporary" package and that it won't be found otherwise from
the regular repos. This is the case in the CI of
fedora-coreos-configwhere we use
overrides/rpmto test composes with overrides withouthaving to tag them into the pool first.
Related: coreos/fedora-coreos-config#365
Closes: #1117