Include Anaconda in the container

[cgwalters]

It's part of the implementation detail of cosa. Let's embed
it inside our container rather than downloading it dynamically.
This ensures that if you have the container you have all of the tools;
there's nothing separate to deal with and mirror.

It makes building the container more painful, but eh.

[ajeddeloh]

Let's not. We're working on removing this, and what we have works right now. This is more churn for me.

[cgwalters]

This is deleting some of the same code you're deleting though, can't imagine rebasing is that hard?

[ajeddeloh]

Sure, but I'm already spending about 30% of my time when I work on that just fighting rebases, this makes it pretty easy to miss deleting it in the new location. In general it'd be great to not churn on the anaconda bits.

[cgwalters]

I'll be happy to rebase your branch after this lands for you if you prefer, I just glanced at it and it looks easy to me.

[dustymabe]

@cgwalters want to provide some context on what problem this solves? Might help the discussion.

[cgwalters]

@cgwalters want to provide some context on what problem this solves? Might help the discussion.

The "and mirror." is the problem this is attempting to address. Like #335

For RHCOS the mirroring thing is still an issue. Having it in the container means that goes away.

[dustymabe]

For RHCOS the mirroring thing is still an issue

i.e. you aren't caching the /srv/installer directory and it fails to download sometimes ?

[cgwalters]

i.e. you aren't caching the /srv/installer directory and it fails to download sometimes

More that we don't want to depend on Internet availability, and I'd rather not rely on a "cache" that's distinct from the container image.

[ajeddeloh]

Don't we already rely on internet for downloading RPMs when we do the compose? I agree eventually we want to get there though.

[cgwalters]

Don't we already rely on internet for downloading RPMs when we do the compose?

FCOS does, RHCOS doesn't.

[dustymabe]

philosophy aside - since we're removing anaconda very soon this conversation doesn't matter too much - so let's unblock but also let's make sure we don't break

i'll build review/build container/test the changes in a bit (have to step away from keyboard for now)

[ajeddeloh]

If it's solving a problem we're facing right now, lets do it, but if its just a refactor/code cleanlyness lets not.

[dustymabe]

requested a few changes - since I wanted to go ahead and test that it works I made those changes in a local branch and ran a test (on FCOS). Submitted those up as a new PR: #381 - if we agree with the approach we can close this and work there.

[dustymabe]

LGTM with the new dir.. I haven't tested this new version. if you've tested then 👍 for merge.

[cgwalters]

Yep, I tested.