src/cmdlib.sh: Allow use of a mirrors for getting the installer ISO.

[darkmuggle]

Allow use of a mirror for the installer image.

[dustymabe]

not sure I quite understand. https://download.fedoraproject.org will send you to a mirror. https://dl.fedoraproject.org is the URL that won't.

[cgwalters]

I think is more about using a local/internal mirror.

[miabbott]

This is not a knock on this change, but this filename is not static:

F27 - https://fedora.mirror.constant.com/fedora/linux/releases/27/Everything/x86_64/iso/Fedora-Everything-netinst-x86_64-27-1.6.iso
F28 - https://fedora.mirror.constant.com/fedora/linux/releases/28/Everything/x86_64/iso/Fedora-Everything-netinst-x86_64-28-1.1.iso
F29 - https://fedora.mirror.constant.com/fedora/linux/releases/29/Everything/x86_64/iso/Fedora-Everything-netinst-x86_64-29-1.2.iso

[dustymabe]

yeah if the intent here is to use F28 instead of F29 then ti's not going to work because f28 went out on the first beta candidate (1.1) where f29 went out on the 2nd beta candidate (1.2) so there is still a difference in the filename.

[darkmuggle]

The intent on the PR was not to change the static filenames; I would consider that a separate PR. My intent was to allow a user-specified mirror/location for the bits.

Adding a lookup would be easy enough:

suffix=""
case $release in
    27) echo 'srly?'; suffix=1.6;;
    28) suffix=1.1;;
    29) suffix=1.2;;
      *) echo "unkown release"; exit 10;;
esac

But given that our stated intent is to remove the need for an installer URL, it seems unnecessary.

[darkmuggle]

I think is more about using a local/internal mirror.

Correct. The intent is to allow someone to pick a local mirror.

[cgwalters]

We should probably accept a URL to a treeinfo file: https://dl.fedoraproject.org/pub/fedora/linux/releases/29/Everything/x86_64/os/.treeinfo

And then parse that.

[dustymabe]

since our goal is to get rid of anaconda and we already have the INSTALLER_OVERRIDE vars is it worth perfecting this?

[miabbott]

since our goal is to get rid of anaconda and we already have the INSTALLER_OVERRIDE vars is it worth perfecting this?

Probably not. But if this change helps the RHCOS pipeline, I'm OK with merging it.

[dustymabe]

But if this change helps the RHCOS pipeline, I'm OK with merging it.

+1 if it helps.. I maybe just need some more context.

[darkmuggle]

Ugh, I have been heads down and missed this.

The short-story is the when running COSA behind the Red Hat firewall, download.fedoraproject.org is dreadfully slow. Having the ability to switch to a known internal URL would make it faster. Right now we do something like this:

        def builder_iso = "http://download.devel.redhat.com/released/F-28/GOLD/Everything/x86_64/iso/Fedora-Everything-netinst-x86_64-28-1.1.iso";
        def builder_checksum = "http://download.devel.redhat.com/released/F-28/GOLD/Everything/x86_64/iso/Fedora-Everything-28-1.1-x86_64-CHECKSUM";

        stage('Fetch ISO') {
            sh_wrap("""
            mkdir -p installer
            (cd installer && curl -L -O ${builder_iso} ${builder_checksum} )
            """);
        }

With INSTALLER_MIRROR we can just add it as an envVar during the init stage.

[dustymabe]

so the additional sugar this PR adds is that we have to only define one env var vs two?

INSTALLER_MIRROR=http://download.devel.redhat.com

vs

INSTALLER_URL_OVERRIDE=http://download.devel.redhat.com/released/F-28/GOLD/Everything/x86_64/iso/Fedora-Everything-netinst-x86_64-28-1.1.iso
INSTALLER_CHECKSUM_URL_OVERRIDE=http://download.devel.redhat.com/released/F-28/GOLD/Everything/x86_64/iso/Fedora-Everything-netinst-x86_64-28-1.1.iso

?

[darkmuggle]

Correct, it defines a single URL with the assumption that replacing ".iso" w/ "-CHECKSUM" will yield the proper result.

[dustymabe]

If tests look good I'm 👍

[dustymabe]

hit an issue with a build I was doing today:

awk: fatal: cannot open file `/srv/installer/Fedora-Everything-netinst-x86_64-29-1.2-CHECKSUM' for reading (No such file or directory)
+ rc=2
+ set +x
[dustymabe@media fedora-assembler]$ ls /srv/
[dustymabe@media fedora-assembler]$ ls installer/
Fedora-Everything-29-1.2-x86_64-CHECKSUM  Fedora-Everything-netinst-x86_64-29-1.2.iso

Looks like it might be related to this change.