v2: Include Anaconda in the container#381
Closed
dustymabe wants to merge 2 commits intocoreos:masterfrom
Closed
Conversation
It's part of the implementation detail of cosa. Let's embed it inside our container rather than downloading it dynamically. This ensures that if you have the container you have *all* of the tools; there's nothing separate to deal with and mirror. It makes building the container more painful, but eh.
Since a lot of people bind mount over /usr/lib/coreos-assembler/ directory during local development let's use a different directory for the anaconda installer ISO. Also since the ISO gets pulled/installed during container build there is no reason to add any logic for cleaning up. If the ISO fails to download/validate checksum then the container build will fail.
Member
Author
|
With this the container I built was |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #380
From #380 description: