Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling errors caught by codespell #1150

Closed
wants to merge 1 commit into from
Closed

Fix spelling errors caught by codespell #1150

wants to merge 1 commit into from

Conversation

amritbrar
Copy link

See also: #1146

@softwarefactory-project-zuul
Copy link

Build failed.

❌ unit-test RETRY_LIMIT in 6m 41s
❌ unit-test-migration-path-for-coreos-toolbox RETRY_LIMIT in 6m 42s
❌ system-test-fedora-rawhide RETRY_LIMIT in 26m 15s
❌ system-test-fedora-36 RETRY_LIMIT in 6m 44s
❌ system-test-fedora-35 RETRY_LIMIT in 6m 55s

@amritbrar amritbrar closed this Nov 5, 2022
@amritbrar amritbrar deleted the fix-spelling branch November 5, 2022 00:40
debarshiray
debarshiray reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@debarshiray debarshiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, @amritbrar ! Why did you delete your branch and close this pull request?

By the way, could you please use a working email address for Git?

src/cmd/completion.go
@@ -62,7 +62,7 @@ func completionCommands(cmd *cobra.Command, _ []string, _ string) ([]string, cob
commandNames := []string{}
commands := cmd.Root().Commands()
for _, command := range commands {
if strings.Contains(command.Name(), "complet") {
if strings.Contains(command.Name(), "complete") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there was a deliberate desire to search for a sub-string or check the prefix here? It's curious that it uses strings.Contains instead of a simpler comparison.

@debarshiray
Copy link
Member

The tests seem to have failed because of some networking problems.

For example:

[11/13] Generating src/toolbox with a custom command
FAILED: src/toolbox 
/home/zuul-worker/src/github.com/containers/toolbox/src/go-build-wrapper /home/zuul-worker/src/github.com/containers/toolbox/src /home/zuul-worker/src/github.com/containers/toolbox/builddir src/toolbox 0.0.99.3 cc /lib64/ld-linux-x86-64.so.2 false
go: github.com/spf13/[email protected] requires
	gopkg.in/[email protected]: unrecognized import path "gopkg.in/yaml.v2": reading https://gopkg.in/yaml.v2?go-get=1: 502 Bad Gateway
	server response: Cannot obtain refs from GitHub: cannot talk to GitHub: Get https://github.com/go-yaml/yaml.git/info/refs?service=git-upload-pack: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
go: downloading github.com/fsnotify/fsnotify v1.5.1

... and:

go: github.com/spf13/[email protected] requires
	gopkg.in/[email protected]: unrecognized import path "gopkg.in/yaml.v2": reading https://gopkg.in/yaml.v2?go-get=1: 502 Bad Gateway
	server response: Cannot obtain refs from GitHub: cannot talk to GitHub: Get https://github.com/go-yaml/yaml.git/info/refs?service=git-upload-pack: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
ninja: build stopped: subcommand failed.

@debarshiray
Copy link
Member

Thanks for the fixes, @amritbrar ! Why did you delete your branch and close this pull request?

Was it because of #1149 from @nievesmontero ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debarshiray debarshiray debarshiray left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amritbrar @debarshiray