Integrate codespell on toolbox code #1149

nievesmontero · 2022-11-02T11:43:58Z

No description provided.

softwarefactory-project-zuul · 2022-11-02T12:46:22Z

Build succeeded.

✔️ unit-test SUCCESS in 7m 36s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 7m 36s
✔️ system-test-fedora-rawhide SUCCESS in 33m 26s
✔️ system-test-fedora-36 SUCCESS in 10m 30s
✔️ system-test-fedora-35 SUCCESS in 10m 29s

debarshiray

Thanks for working on this, @nievesmontero

src/cmd/completion.go

meson.build

softwarefactory-project-zuul · 2022-11-15T14:51:32Z

Build succeeded.

✔️ unit-test SUCCESS in 7m 42s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 7m 41s
✔️ system-test-fedora-rawhide SUCCESS in 27m 37s
✔️ system-test-fedora-36 SUCCESS in 10m 01s
✔️ system-test-fedora-35 SUCCESS in 11m 00s

containers#1166 containers#1149 Signed-off-by: Nieves Montero <[email protected]>

debarshiray

I split the commit that fixes the existing spelling mistakes into #1166 and merged it.

softwarefactory-project-zuul · 2022-11-17T13:18:46Z

Build succeeded.

✔️ unit-test SUCCESS in 8m 58s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 8m 46s
✔️ system-test-fedora-rawhide SUCCESS in 26m 10s
✔️ system-test-fedora-36 SUCCESS in 11m 27s
✔️ system-test-fedora-35 SUCCESS in 13m 06s

debarshiray

Thanks for the updates! Could you please remove this patch from this pull request? Like I said before, it has already been merged via #1166

debarshiray · 2022-11-17T16:45:12Z

Could you please remove this patch from this pull request? Like I
said before, it has already been merged via #1166

Try git rebase -i main while sitting inside your branch and remove the line describing this patch.

debarshiray · 2022-11-18T07:01:59Z

recheck

debarshiray

Nitpick: you can drop this line from your commit message:

Codespell has been added to the meson.build file and has been tested.

... because that's obvious from looking at the commit.

meson.build

softwarefactory-project-zuul · 2022-11-18T07:34:24Z

Build succeeded.

✔️ unit-test SUCCESS in 8m 39s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 8m 40s
✔️ system-test-fedora-rawhide SUCCESS in 31m 34s
✔️ system-test-fedora-36 SUCCESS in 11m 32s
✔️ system-test-fedora-35 SUCCESS in 12m 22s

softwarefactory-project-zuul · 2022-11-18T12:59:20Z

Build failed.

❌ unit-test RETRY_LIMIT in 8m 16s
❌ unit-test-migration-path-for-coreos-toolbox RETRY_LIMIT in 8m 32s
❌ system-test-fedora-rawhide RETRY_LIMIT in 31m 16s
❌ system-test-fedora-36 RETRY_LIMIT in 8m 12s
❌ system-test-fedora-35 RETRY_LIMIT in 8m 12s

debarshiray · 2022-11-18T15:49:25Z

The tests are failing with:

meson.build:62: WARNING: Project targeting '>= 0.58.0' but tried
    to use feature deprecated since '0.56.0': meson.source_root. use
    meson.project_source_root() or meson.global_source_root() instead.

meson.build:62:2: ERROR: Fatal warnings enabled, aborting

debarshiray

Thanks for the updates, @nievesmontero !

debarshiray · 2022-11-18T15:54:04Z

meson.build

@@ -57,6 +58,10 @@ if shellcheck.found()
  test('shellcheck toolbox (deprecated)', shellcheck, args: [toolbox_sh])
 endif

+if codespell.found()
+  test('codespell toolbox', codespell, args: ['--skip', meson.project_build_root(), meson.source_root()])


It should be meson.project_source_root(), not meson.source_root(). See the test failures.

softwarefactory-project-zuul · 2022-11-18T17:09:54Z

Build failed.

❌ unit-test FAILURE in 8m 28s
❌ unit-test-migration-path-for-coreos-toolbox FAILURE in 8m 41s
✔️ system-test-fedora-rawhide SUCCESS in 36m 33s
✔️ system-test-fedora-36 SUCCESS in 11m 22s
✔️ system-test-fedora-35 SUCCESS in 12m 07s

debarshiray · 2022-11-19T12:18:18Z

Thanks for the updates, @nievesmontero !

Build failed.

x unit-test FAILURE in 8m 28s x unit-test-migration-path-for-coreos-toolbox FAILURE in 8m 41s

Now that the codespell test is actually getting run, it's failing:

TASK [Test]
ci-node-36 | ninja: Entering directory `/home/zuul-worker/src/github.com/containers/toolbox/builddir'
ci-node-36 | ninja: no work to do.
ci-node-36 | 1/6 shellcheck src/go-build-wrapper OK              0.04s
ci-node-36 | 2/6 go fmt                          OK              0.05s
ci-node-36 | 3/6 shellcheck profile.d/toolbox.sh OK              0.06s
ci-node-36 | 4/6 codespell toolbox               FAIL            0.33s   exit status 65
ci-node-36 | >>> MALLOC_PERTURB_=94 /usr/bin/codespell --skip /home/zuul-worker/src/github.com/containers/toolbox/builddir /home/zuul-worker/src/github.com/containers/toolbox
ci-node-36 |
ci-node-36 | 5/6 shellcheck toolbox (deprecated) OK              1.05s
ci-node-36 | 6/6 toolbox go unit tests           OK              2.73s
ci-node-36 |
ci-node-36 |
ci-node-36 | Ok:                 5
ci-node-36 | Expected Fail:      0
ci-node-36 | Fail:               1
ci-node-36 | Unexpected Pass:    0
ci-node-36 | Skipped:            0
ci-node-36 | Timeout:            0
ci-node-36 |
ci-node-36 | Full log written to /home/zuul-worker/src/github.com/containers/toolbox/builddir/meson-logs/testlog.txt
ci-node-36 | ERROR
ci-node-36 | {
ci-node-36 |   "delta": "0:00:03.005543",
ci-node-36 |   "end": "2022-11-18 16:41:18.320047",
ci-node-36 |   "msg": "non-zero return code",
ci-node-36 |   "rc": 1,
ci-node-36 |   "start": "2022-11-18 16:41:15.314504"
ci-node-36 | }

softwarefactory-project-zuul · 2022-11-19T12:52:35Z

Build failed.

❌ unit-test FAILURE in 8m 37s
❌ unit-test-migration-path-for-coreos-toolbox FAILURE in 8m 38s
✔️ system-test-fedora-rawhide SUCCESS in 37m 35s
✔️ system-test-fedora-36 SUCCESS in 14m 52s
✔️ system-test-fedora-35 SUCCESS in 16m 17s

containers#1146 Signed-off-by: Nieves Montero <[email protected]>

debarshiray · 2022-11-19T14:39:22Z

Now that the codespell test is actually getting run, it's failing:

It's because of that "complet" prefix, and a spelling mistake in the bats-support Git submodule in test/system/libs/bats-support.

I do wish codespell offered inline directives to ignore such one-off cases.

softwarefactory-project-zuul · 2022-11-19T15:14:46Z

Build succeeded.

✔️ unit-test SUCCESS in 8m 22s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 8m 23s
✔️ system-test-fedora-rawhide SUCCESS in 33m 44s
✔️ system-test-fedora-36 SUCCESS in 11m 13s
✔️ system-test-fedora-35 SUCCESS in 12m 03s

debarshiray · 2022-11-19T15:17:59Z

Now that the codespell test is actually getting run, it's failing:

It's because of that "complet" prefix, and a spelling mistake in the bats-support Git submodule in test/system/libs/bats-support.

I do wish codespell offered inline directives to ignore such one-off cases.

I took the liberty to fix this up, and extended the test to cover filenames and hidden files too.

debarshiray · 2022-11-19T15:18:22Z

Thanks for working on this, @nievesmontero !

debarshiray mentioned this pull request Nov 8, 2022

Fix spelling errors caught by codespell #1150

Closed

debarshiray requested changes Nov 8, 2022

View reviewed changes

src/cmd/completion.go Outdated Show resolved Hide resolved

meson.build Outdated Show resolved Hide resolved

meson.build Outdated Show resolved Hide resolved

meson.build Show resolved Hide resolved

nievesmontero force-pushed the codespell branch from 0cb9ff3 to cf6ef2e Compare November 15, 2022 14:22

debarshiray mentioned this pull request Nov 17, 2022

Fix spelling mistakes using codespell #1166

Merged

debarshiray pushed a commit to debarshiray/toolbox that referenced this pull request Nov 17, 2022

Fix spelling mistakes using codespell

f2b7e44

containers#1166 containers#1149 Signed-off-by: Nieves Montero <[email protected]>

debarshiray reviewed Nov 17, 2022

View reviewed changes

nievesmontero force-pushed the codespell branch from cf6ef2e to 8619e56 Compare November 17, 2022 12:52

debarshiray requested changes Nov 17, 2022

View reviewed changes

debarshiray requested changes Nov 18, 2022

View reviewed changes

meson.build Outdated Show resolved Hide resolved

nievesmontero force-pushed the codespell branch from 8619e56 to 4c15346 Compare November 18, 2022 11:31

debarshiray requested changes Nov 18, 2022

View reviewed changes

nievesmontero force-pushed the codespell branch 2 times, most recently from c1e3a29 to 1518e5a Compare November 18, 2022 16:32

debarshiray force-pushed the codespell branch from 1518e5a to 7dc40a5 Compare November 19, 2022 12:13

build, playbooks: Add a test that runs codespell

9438db2

containers#1146 Signed-off-by: Nieves Montero <[email protected]>

debarshiray force-pushed the codespell branch from 7dc40a5 to 9438db2 Compare November 19, 2022 14:39

debarshiray merged commit 9438db2 into containers:main Nov 19, 2022

debarshiray mentioned this pull request Nov 19, 2022

Add codespell to the tests #1146

Closed

nievesmontero deleted the codespell branch October 3, 2023 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate codespell on toolbox code #1149

Integrate codespell on toolbox code #1149

nievesmontero commented Nov 2, 2022

softwarefactory-project-zuul bot commented Nov 2, 2022

debarshiray left a comment

softwarefactory-project-zuul bot commented Nov 15, 2022

debarshiray left a comment

softwarefactory-project-zuul bot commented Nov 17, 2022

debarshiray left a comment

debarshiray commented Nov 17, 2022

debarshiray commented Nov 18, 2022

debarshiray left a comment

softwarefactory-project-zuul bot commented Nov 18, 2022

softwarefactory-project-zuul bot commented Nov 18, 2022

debarshiray commented Nov 18, 2022 •

edited

Loading

debarshiray left a comment

debarshiray Nov 18, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Nov 18, 2022

debarshiray commented Nov 19, 2022

softwarefactory-project-zuul bot commented Nov 19, 2022

debarshiray commented Nov 19, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Nov 19, 2022

debarshiray commented Nov 19, 2022

debarshiray commented Nov 19, 2022

Integrate codespell on toolbox code #1149

Integrate codespell on toolbox code #1149

Conversation

nievesmontero commented Nov 2, 2022

softwarefactory-project-zuul bot commented Nov 2, 2022

debarshiray left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 15, 2022

debarshiray left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 17, 2022

debarshiray left a comment

Choose a reason for hiding this comment

debarshiray commented Nov 17, 2022

debarshiray commented Nov 18, 2022

debarshiray left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 18, 2022

softwarefactory-project-zuul bot commented Nov 18, 2022

debarshiray commented Nov 18, 2022 • edited Loading

debarshiray left a comment

Choose a reason for hiding this comment

debarshiray Nov 18, 2022 • edited Loading

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 18, 2022

debarshiray commented Nov 19, 2022

softwarefactory-project-zuul bot commented Nov 19, 2022

debarshiray commented Nov 19, 2022 • edited Loading

softwarefactory-project-zuul bot commented Nov 19, 2022

debarshiray commented Nov 19, 2022

debarshiray commented Nov 19, 2022

debarshiray commented Nov 18, 2022 •

edited

Loading

debarshiray Nov 18, 2022 •

edited

Loading

debarshiray commented Nov 19, 2022 •

edited

Loading