Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codespell to the tests #1146

Closed
debarshiray opened this issue Oct 23, 2022 · 1 comment
Closed

Add codespell to the tests #1146

debarshiray opened this issue Oct 23, 2022 · 1 comment
Assignees
@nievesmontero
Labels
2. Build System Issue is related to the build system 2. CI Automation of testing, analysis and other actions

Comments

@debarshiray
Copy link
Member

debarshiray commented Oct 23, 2022 •
edited
Loading

It will be good to add codespell to our test suite to catch spelling mistakes. It should be easy to run it on the files in src, doc, data, profile.d, etc., because Meson already knows about them. The image definitions in images and the test-suite in test are not currently tracked by Meson, so those might need some thought.

Podman also uses codespell, so it can provide some guidance.

There are currently some mistakes in src. Spotting them is left as a fun exercise. ;)
@debarshiray debarshiray added 1. Feature request A request for a new feature 2. CI Automation of testing, analysis and other actions 2. Build System Issue is related to the build system and removed 1. Feature request A request for a new feature labels Oct 23, 2022
nievesmontero added a commit to nievesmontero/toolbox that referenced this issue Nov 2, 2022
@nievesmontero
Integrate codespell on toolbox code
0cb9ff3 
Codespell has been added to the meson.build file and has been tested.
Fixed containers#1146

Signed-off-by: Nieves Montero <[email protected]>
@amritbrar amritbrar mentioned this issue Nov 4, 2022
Closed
nievesmontero added a commit to nievesmontero/toolbox that referenced this issue Nov 15, 2022
@nievesmontero
Integrate codespell on toolbox code
cf6ef2e 
Codespell has been added to the meson.build file and has been tested.
Fixed containers#1146

Signed-off-by: Nieves Montero <[email protected]>
nievesmontero added a commit to nievesmontero/toolbox that referenced this issue Nov 17, 2022
@nievesmontero
Integrate codespell on toolbox code
8619e56 
Codespell has been added to the meson.build file and has been tested.
Fixed containers#1146

Signed-off-by: Nieves Montero <[email protected]>
nievesmontero added a commit to nievesmontero/toolbox that referenced this issue Nov 18, 2022
@nievesmontero
Integrate codespell on toolbox code
4c15346 
Fixed containers#1146

Signed-off-by: Nieves Montero <[email protected]>
nievesmontero added a commit to nievesmontero/toolbox that referenced this issue Nov 18, 2022
@nievesmontero
Integrate codespell on toolbox code
c1e3a29 
Fixed containers#1146

Signed-off-by: Nieves Montero <[email protected]>
nievesmontero added a commit to nievesmontero/toolbox that referenced this issue Nov 18, 2022
@nievesmontero
Integrate codespell on toolbox code
1518e5a 
Fixed containers#1146

Signed-off-by: Nieves Montero <[email protected]>
debarshiray pushed a commit to nievesmontero/toolbox that referenced this issue Nov 19, 2022
@nievesmontero @debarshiray
build, playbooks: Add a test that runs codespell
7dc40a5 
containers#1146

Signed-off-by: Nieves Montero <[email protected]>
debarshiray pushed a commit to nievesmontero/toolbox that referenced this issue Nov 19, 2022
@nievesmontero @debarshiray
build, playbooks: Add a test that runs codespell
9438db2 
containers#1146

Signed-off-by: Nieves Montero <[email protected]>
@debarshiray
Copy link
Member Author

Done in #1149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nievesmontero nievesmontero

Labels
2. Build System Issue is related to the build system 2. CI Automation of testing, analysis and other actions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@debarshiray @nievesmontero