Skip to content

Conversation

@cevich
Copy link
Member

@cevich cevich commented Apr 23, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2019
@rhatdan
Copy link
Member

rhatdan commented Apr 23, 2019

LGTM

@edsantiago
Copy link
Member

edsantiago commented Apr 23, 2019

Broken by b87bdce. Solution: change iproute to iproute2 (in ubuntu only)

@cevich
Copy link
Member Author

cevich commented Apr 23, 2019

Images built successfully: https://cirrus-ci.com/task/5754003001442304

Converting them into VM images now using command e.g.:

sudo podman run -it --rm -e AS_ID=$UID -e AS_USER=$USER -v /home/$USER:$HOME \
--security-opt label=disable quay.io/cevich/gcloud_centos:latest compute images create \
--source-uri gs://packer-import/fedora-29-libpod-548c1c05.tar.gz \
fedora-29-libpod-548c1c05

Once that finishes I'll remove the test-commit here, update .cirrus.yml and --force push.

@mheon
Copy link
Member

mheon commented Apr 23, 2019

@cevich According to @rhatdan in IRC we needed a newer build of container-selinux that just hit Koji, so I think we might need a respin in a few hours...

@cevich
Copy link
Member Author

cevich commented Apr 23, 2019

@mheon oh ok, well just ping me and I'll roll 'em again. Updating with the ones I made, just as a trial-run, see if anything else breaks...

@edsantiago
Copy link
Member

we needed a newer build of container-selinux that just hit Koji, so I think we might need a respin in a few hours...

May I give that a try? I could piggyback it onto my #2956. I would very much like to understand the process for updating cache images, and to update the documentation.

@cevich
Copy link
Member Author

cevich commented Apr 24, 2019

@edsantiago of course you may, thank you for volunteering! The process is long-in-waiting to be streamlined. I've been working a PR to automate the build and validate the build by running the tests, but it's challenging (the validation part). Perhaps a fresh pair of eyes will bring new insight, as what we have currently is for sure, far out-dated. I'll ping you on IRC so we can go over the undocumented bits...which should probably remain undocumented (they need to be removed entirely).

cevich added 4 commits April 24, 2019 14:25
Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich changed the title WIP: Libsystemd dev + newer runc Libsystemd dev + newer runc Apr 26, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2019
@baude
Copy link
Member

baude commented Apr 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@baude
Copy link
Member

baude commented Apr 26, 2019

/lgtm

@baude
Copy link
Member

baude commented Apr 26, 2019

/approved

@baude
Copy link
Member

baude commented Apr 26, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, cevich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@openshift-merge-robot openshift-merge-robot merged commit a851556 into containers:master Apr 26, 2019
@cevich cevich deleted the libsystemd_dev branch June 30, 2021 18:03
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants