Cirrus: Support testing of VM cache-image changes #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
Author
|
/cc @baude |
cevich
force-pushed
the
cirrus_test_images
branch
from
5f5246c to
9d05a26
Compare
Member
Author
|
Okay, so the task output from Cirrus was: Those can get convered into images for use in |
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
cevich
force-pushed
the
cirrus_test_images
branch
8 times, most recently
from
4932b26 to
8c952c2
Compare
openshift-ci-robot
added
the
needs-rebase
cevich
force-pushed
the
cirrus_test_images
branch
from
8c952c2 to
fe94c6e
Compare
openshift-ci-robot
removed
the
needs-rebase
cevich
force-pushed
the
cirrus_test_images
branch
from
fe94c6e to
e2a99dd
Compare
Collaborator
|
☔ The latest upstream changes (presumably #2689) made this pull request unmergeable. Please resolve the merge conflicts. |
cevich
force-pushed
the
cirrus_test_images
branch
4 times, most recently
from
bc0ba7a to
db08e30
Compare
edsantiago
reviewed
May 20, 2019
Member
|
LGTM; but most of what I did was diff against 55361d74. /lgtm |
Member
Author
That's fine, thanks for doing a final pass. Okay, I'll do (hopefully) the last rebase and push with the updated comments re: the disk resize workaround... |
Hack was to workaround not having fix for: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b4356521ba Update `RUNC_COMMIT` value to match commit id to working package. Signed-off-by: Chris Evich <cevich@redhat.com>
Previously, it was quite difficult to affect changes to VM cache images without lots of manual work. This commit adds a new optional testing task which mirrors the official-image build task which only runs on master. In contrast, the new task may be run at any time in a PR, but including a magic phrase in the PR description. Update documentation to describe the new task and inform on it's usage. Signed-off-by: Chris Evich <cevich@redhat.com>
Also, add jq and catatonit installs to images. Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
Also remove disused distros (RHEL/CentOS/FAH) and fix get_ci_vm script Signed-off-by: Chris Evich <cevich@redhat.com>
New base-image boots, a cache-image builds, but more work is needed for it to be prime-time ready. This commit just adds some updates to the scafolding necessary to build the base-image. Future work will make F30 more of a reality. Also add log-collection scripts to test image verification task Signed-off-by: Chris Evich <cevich@redhat.com>
Occasionally, and seemingly only on F29 the root disk fails to expand upon boot. When this happens, any number of failures could occur if space runs out. Until there is time to investigate the actual cause, workaround this problem by detecting it and acting accordingly. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
force-pushed
the
cirrus_test_images
branch
from
132bb1d to
c7d9780
Compare
Member
Author
|
note: Image-build testing is happening over on PR #3078 (rebased against this one). |
Signed-off-by: Chris Evich <cevich@redhat.com>
Member
Author
|
Oh hey, look at that, PR #3078 found a problem. Fixing... |
Member
Author
|
/hold cancel Okay here and the image-build workflow is functional as well |
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
Author
|
@edsantiago may I trouble for one more /lgtm ? |
Member
|
/lgtm (ignoring typo in comment; please let's just move past this) |
This was referenced May 21, 2019
Member
Author
|
Thanks again @edsantiago - and sorry for the PR size 😕 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was quite difficult to affect changes to VM cache images
without lots of manual work. This commit adds a new optional testing
task which mirrors the official-image build task which only runs on
master. In contrast, the new task may be run at any time in a PR, but
including a magic phrase in the PR description:
Update documentation to describe the new task and inform on it's usage.
Signed-off-by: Chris Evich cevich@redhat.com