Skip to content

Conversation

@edsantiago
Copy link
Member

Follow directions in contrib/cirrus/README.md to add 'jq'.

Signed-off-by: Ed Santiago [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: edsantiago
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vrothberg

If they are not already assigned, you can assign the PR to them by writing /assign @vrothberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago edsantiago force-pushed the cirrus_add_jq branch 2 times, most recently from 4fd686d to 5731bf4 Compare April 22, 2019 20:10
Follow directions in contrib/cirrus/README.md to add 'jq'.

Also: b87bdce seems to have broken ubuntu:

   E: Package 'iproute' has no installation candidate

Try 'iproute2' instead.

Signed-off-by: Ed Santiago <[email protected]>
@cevich
Copy link
Member

cevich commented Apr 26, 2019

@edsantiago We're merging #2991 (you said you wanted to try it) b/c brent reminded me, it fixes a flake which is affecting all PRs. However, I can still help get this PR in next week (independent of #2561) if you like. Despite being somewhat of a pain, the manual steps aren't difficult, just require lots of waiting (the gcloud compute images create command is VERY slow).

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2991) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot
Copy link
Collaborator

@edsantiago: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2019
@mheon
Copy link
Member

mheon commented Apr 30, 2019

@edsantiago Are you handling this one with @cevich in the other Cirrus PR for updating/testing images?

@edsantiago
Copy link
Member Author

@mheon this PR is almost definitely going to be closed; I'm hoping that #2561 takes care of it. I wanted to leave it open as a backup; but if open PRs are causing noise, please feel free to close.

@mheon
Copy link
Member

mheon commented Apr 30, 2019

Naw, just doing status checks on open PRs to see what I can get merged - feel free to keep open

@edsantiago edsantiago closed this May 23, 2019
@edsantiago edsantiago deleted the cirrus_add_jq branch June 25, 2020 19:54
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants