Revert "Switch to golangci-lint"

[baude]

Signed-off-by: baude [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

if this works, merge it and hope we're back to just working ...

[vrothberg]

LGTM but please explain why it’s needed to revert

[rhatdan]

I am attempting to make golangci-lint work in #2867

[baude]

LGTM but please explain why it’s needed to revert

because it broke us on prow and our CI is dead

[mheon]

Why did we merge this when it wasn't passing CI?

…

On Sat, Apr 6, 2019, 10:54 Brent Baude ***@***.***> wrote: LGTM but please explain why it’s needed to revert because it broke us on prow and our CI is dead — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2865 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHYHCPOMNQcL6SRqA_n_IheB8jpsLh8Uks5veLUQgaJpZM4cf7jE> .

[mheon]

Regardless, I'm with Brent here. If we don't have a fix soon I'm going to merge the revert so we can unblock PRs

…

On Sat, Apr 6, 2019, 10:58 Matthew Heon ***@***.***> wrote: Why did we merge this when it wasn't passing CI? On Sat, Apr 6, 2019, 10:54 Brent Baude ***@***.***> wrote: > LGTM but please explain why it’s needed to revert > > because it broke us on prow and our CI is dead > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <#2865 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHYHCPOMNQcL6SRqA_n_IheB8jpsLh8Uks5veLUQgaJpZM4cf7jE> > . >

[baude]

because chris asked dan to ... i alerted chris to the problem immediately but he went on to PTO

[baude]

the core issue is the linter has to be setup for the tests we do in openshift containers too. that was not done and i think we should revert until chris is back from pto.

[mheon]

@baude Based on Steve's comments elsewhere - do we want to update the Dockerfiles for ci/prow/lint instead of this? It seems like that's our last blocker on this.

I'm still open to merging this is we need to unblock stuff ASAP.

[giuseppe]

let's merge. It is blocking all our PRs. We can reintroduce golangci-lint when it works.

/lgtm