Skip to content

podman-remote create|run #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 8, 2019
Merged

podman-remote create|run #2746

openshift-merge-robot merged 1 commit into from
Apr 8, 2019

Conversation

@baude
Copy link
Member

@baude baude commented Mar 22, 2019

add the ability to create and run containers via the podman-remote
client.

we now create an intermediate layer from the the create/run cli flags.
the intermediate layer can be converted into a createconfig or into a
varlink struct. Once transported, the varlink struct can be converted
back to an intermediate layer and then to a createconfig.

remote terminals are not supported yet.

Signed-off-by: baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2019
@baude
Copy link
Member Author

baude commented Mar 22, 2019

I will enable tests on the next PR

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 22, 2019
@baude baude force-pushed the remotecreate branch 7 times, most recently from 35d187a to 18a96f1 Compare March 25, 2019 00:24
@baude
Copy link
Member Author

baude commented Mar 25, 2019

the test failures look legit ... ill dig into them today.

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Mar 26, 2019

☔ The latest upstream changes (presumably #2758) made this pull request unmergeable. Please resolve the merge conflicts.

@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2019

@baude Needs a rebase.

@baude baude force-pushed the remotecreate branch 2 times, most recently from da01544 to a97c056 Compare April 1, 2019 00:35
mheon
mheon reviewed Apr 1, 2019
View reviewed changes
mheon
mheon reviewed Apr 1, 2019
View reviewed changes
mheon
mheon reviewed Apr 1, 2019
View reviewed changes
mheon
mheon reviewed Apr 1, 2019
View reviewed changes
mheon
mheon reviewed Apr 1, 2019
View reviewed changes
mheon
mheon reviewed Apr 1, 2019
View reviewed changes
mheon
mheon reviewed Apr 1, 2019
View reviewed changes
@baude
Copy link
Member Author

baude commented Apr 2, 2019

Varlink API looks strange

@haraldh can you elaborate?

@mheon
Copy link
Member

mheon commented Apr 2, 2019

Code LGTM... Let's get some more reviews on this
@rhatdan @TomSweeneyRedHat @vrothberg @giuseppe

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Apr 2, 2019

LGTM, assuming happy tests, which aren't at the moment.

rhatdan
rhatdan reviewed Apr 3, 2019
View reviewed changes
cmd/podman/shared/intermediate_varlink.go Outdated
Copy link
Member

@rhatdan rhatdan Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are removing EnvFile from being pushed. Should we fix that before this is merged?

pkg/adapter/containers.go Outdated
Copy link
Member

@rhatdan rhatdan Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We probably should change the exitCode to a constant.

@baude baude changed the title podman-remote create|run [wip]podman-remote create|run Apr 3, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2019
larskarlitski
larskarlitski suggested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@larskarlitski larskarlitski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the changes to the varlink API. What's the purpose of CreateResult and why do I need to pass something called Result into a Create API in the first place? It also seems very clunky to use.

@baude
Copy link
Member Author

baude commented Apr 3, 2019

I don't understand the changes to the varlink API. What's the purpose of CreateResult and why do I need to pass something called Result into a Create API in the first place? It also seems very clunky to use.

I would encourage you to be patient. I'm reworking some stuff based on input from harald. And don't get hung up on wording.

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Apr 3, 2019

☔ The latest upstream changes (presumably #2825) made this pull request unmergeable. Please resolve the merge conflicts.

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Apr 8, 2019

☔ The latest upstream changes (presumably #2865) made this pull request unmergeable. Please resolve the merge conflicts.

@baude baude changed the title [wip]podman-remote create|run podman-remote create|run Apr 8, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2019
@baude
Copy link
Member Author

baude commented Apr 8, 2019

OK, this is now reworked to address some of the concerns about the endpoint that were brought up. The endpoint is now simpler and includes mostly nullable options. To deal with this, major rework was done on the remote-client side to deal with lack of context now being sent.

@baude
podman-remote create|run
ba65301 
add the ability to create and run containers via the podman-remote
client.

we now create an intermediate layer from the the create/run cli flags.
the intermediate layer can be converted into a createconfig or into a
varlink struct.  Once transported, the varlink struct can be converted
back to an intermediate layer and then to a createconfig.

remote terminals are not supported yet.

Signed-off-by: baude <[email protected]>
@mheon
Copy link
Member

mheon commented Apr 8, 2019

LGTM
@rhatdan PTAL

@mheon
Copy link
Member

mheon commented Apr 8, 2019

@TomSweeneyRedHat @giuseppe @vrothberg also

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Apr 8, 2019

LGTM.
A few nits that will hopefully be fixed up later.

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Apr 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8eb03d3 into containers:master Apr 8, 2019
This was referenced Apr 8, 2019
Merged
Merged
@baude baude deleted the remotecreate branch December 22, 2019 19:05
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rhatdan rhatdan rhatdan left review comments

@mheon mheon mheon left review comments

@giuseppe giuseppe Awaiting requested review from giuseppe

+1 more reviewer

@larskarlitski larskarlitski larskarlitski requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomSweeneyRedHat TomSweeneyRedHat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@baude @openshift-ci-robot @rh-atomic-bot @rhatdan @haraldh @mheon @TomSweeneyRedHat @larskarlitski @openshift-merge-robot