Skip to content

Cirrus: timestamp all output script output #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
May 3, 2019
Merged

Cirrus: timestamp all output script output #2849

openshift-merge-robot merged 2 commits into from
May 3, 2019

Conversation

@cevich
Copy link
Member

@cevich cevich commented Apr 4, 2019

Signed-off-by: Chris Evich [email protected]

@cevich cevich force-pushed the timestamps branch 21 times, most recently from d7019ec to c4da453 Compare April 4, 2019 18:53
edsantiago
edsantiago reviewed Apr 4, 2019
View reviewed changes
@cevich cevich force-pushed the timestamps branch 3 times, most recently from 8a4bdbf to 6e2b5d2 Compare April 4, 2019 20:21
@cevich cevich changed the title Cirrus: timestamp all output script output WIP: Cirrus: timestamp all output script output Apr 4, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
@cevich
Copy link
Member Author

cevich commented May 1, 2019

(rebased and --force pushed)

@cevich
Copy link
Member Author

cevich commented May 2, 2019

@mheon np, should be fixed now, and I'll rebase/--force push again just to be sure...

@mheon
Copy link
Member

mheon commented May 2, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@mheon
Copy link
Member

mheon commented May 2, 2019

Holding LGTM until tests green

@mheon
Copy link
Member

mheon commented May 2, 2019

Network flake, restarting test

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented May 2, 2019

☔ The latest upstream changes (presumably #3053) made this pull request unmergeable. Please resolve the merge conflicts.

@mheon
Copy link
Member

mheon commented May 2, 2019

@cevich Needs another rebase 😢

cevich added 2 commits May 2, 2019 15:03
@cevich
Cirrus: timestamp all output script output
3ab67b9 
Also remove direct time-stamping by CI scripts that would compete.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Cirrus: Add pipefail confirmation check
074a26f 
Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member Author

cevich commented May 2, 2019

there we go.

@mheon
Copy link
Member

mheon commented May 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@mheon
Copy link
Member

mheon commented May 2, 2019

/retest

1 similar comment
@mheon
Copy link
Member

mheon commented May 2, 2019

/retest

@mheon
Copy link
Member

mheon commented May 2, 2019

Prow failing because of "disk pressure" - that seems like infra to me.

@mheon
Copy link
Member

mheon commented May 2, 2019

@stevekuznetsov Mind taking a look at this when you get a chance?

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented May 2, 2019

Yeah, we are hitting

https://bugzilla.redhat.com/show_bug.cgi?id=1705657

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented May 2, 2019

You should be able to

/retest

@openshift-merge-robot openshift-merge-robot merged commit d9d9c82 into containers:master May 3, 2019
@rh-atomic-bot rh-atomic-bot mentioned this pull request May 3, 2019
Merged
@mheon
Copy link
Member

mheon commented May 3, 2019

Nice - thanks for looking!

@cevich cevich deleted the timestamps branch June 30, 2021 18:03
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rhatdan rhatdan rhatdan left review comments

@baude baude Awaiting requested review from baude

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

+1 more reviewer

@edsantiago edsantiago edsantiago approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@edsantiago edsantiago

@mheon mheon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cevich @edsantiago @rh-atomic-bot @TomSweeneyRedHat @mheon @openshift-ci-robot @stevekuznetsov @rhatdan @openshift-merge-robot