Update containerd/cgroups to fix perf issue #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
mheon
changed the title
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Member
|
LGTM and happy green buttons. @rhatdan PTAL |
Member
Collaborator
|
📌 Commit a417e6e has been approved by |
Member
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit a417e6e has been approved by |
Collaborator
|
⌛ Testing commit a417e6e with merge c03c4ba... |
Collaborator
|
💔 Test failed - status-papr |
Member
|
@rh-atomic-bot retry |
Collaborator
|
⌛ Testing commit a417e6e with merge be9025c... |
Collaborator
|
💔 Test failed - status-papr |
Member
|
Manually merging since homu seems sick. |
wking
added a commit
to wking/libpod
that referenced
this pull request
May 11, 2018
vendor.conf has been pinned at containerd/cgroups@7a5fdd83 (Merge pull request containers#26 from onorua/error-ignore-example, 2017-08-24) since libpod forked from CRI-O with a031b83 (Initial checkin from CRI-O repo, 2017-11-01). The content in vendor/github.com/containerd/cgroups was bumped to containerd/cgroups@77e62851 (Use /proc/diskstats to get device names, 2018-01-31) in ae89dc2 (Update containerd/cgroups repo fix perf issue, 2018-02-01, containers#284), but ae89dc2 forgot to update vendor.conf. With this commit: $ vndr github.com/containerd/cgroups no longer changes anything under vendor/github.com/containerd/cgroups. Signed-off-by: W. Trevor King <wking@tremily.us>
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 11, 2018
vendor.conf has been pinned at containerd/cgroups@7a5fdd83 (Merge pull request #26 from onorua/error-ignore-example, 2017-08-24) since libpod forked from CRI-O with a031b83 (Initial checkin from CRI-O repo, 2017-11-01). The content in vendor/github.com/containerd/cgroups was bumped to containerd/cgroups@77e62851 (Use /proc/diskstats to get device names, 2018-01-31) in ae89dc2 (Update containerd/cgroups repo fix perf issue, 2018-02-01, #284), but ae89dc2 forgot to update vendor.conf. With this commit: $ vndr github.com/containerd/cgroups no longer changes anything under vendor/github.com/containerd/cgroups. Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #749 Approved by: mheon
baude
pushed a commit
to baude/podman
that referenced
this pull request
Aug 31, 2019
IPAM/DHCP: include Subnet Mask option parameter in DHCPREQUEST
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update one of our vendors to pick up an upstream performance fix