Skip to content

Set default configuration container type annotation to sandbox #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhatdan merged 1 commit into from
Feb 2, 2018
Merged

Set default configuration container type annotation to sandbox #282

rhatdan merged 1 commit into from
Feb 2, 2018

Conversation

@randomvariable
Copy link
Contributor

@randomvariable randomvariable commented Feb 1, 2018

This allows podman to provide sufficient hints to
start containers with Intel Clear Containers:
https://github.com/clearcontainers/runtime/blob/master/docs/architecture/architecture.md#oci-annotations

Signed-off-by: Naadir Jeewa naadir@randomvariable.co.uk

@randomvariable
Set default configuration container type annotation to sandbox
21482ad 
This allows podman to provide sufficient hints to
start containers with Intel Clear Containers:
https://github.com/clearcontainers/runtime/blob/master/docs/architecture/architecture.md#oci-annotations

Signed-off-by: Naadir Jeewa <naadir@randomvariable.co.uk>
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 1, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Feb 1, 2018

bot, add author to whitelist

@mheon
Copy link
Member

mheon commented Feb 1, 2018

LGTM

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Feb 1, 2018

LGTM and thanks for the PR @randomvariable!

@rhatdan
Copy link
Member

rhatdan commented Feb 2, 2018

@rh-atomic-bot r+
Cool podman running with Clear Containers. @randomvariable Want to write a blog on this, demonstrate it?

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 2, 2018

📌 Commit 21482ad has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 2, 2018

⌛ Testing commit 21482ad with merge 21ed62c...

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 2, 2018

💔 Test failed - status-papr

@mheon
Copy link
Member

mheon commented Feb 2, 2018

Looks like network flakes.
@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 2, 2018

⌛ Testing commit 21482ad with merge 0328ac3...

@randomvariable
Copy link
Contributor Author

randomvariable commented Feb 2, 2018

Cool podman running with Clear Containers. @randomvariable Want to write a blog on this, demonstrate it?

Happy too. Will probably happen after coming back from FOSDEM & CfgMgmtCamp though.

@rh-atomic-bot rh-atomic-bot mentioned this pull request Feb 2, 2018
Merged
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 2, 2018

💔 Test failed - status-papr

@mheon
Copy link
Member

mheon commented Feb 2, 2018

@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 2, 2018

⌛ Testing commit 21482ad with merge 8ab4ae0...

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 2, 2018

💔 Test failed - status-papr

@mheon
Copy link
Member

mheon commented Feb 2, 2018

@rh-atomic-bot retest

@rhatdan
Copy link
Member

rhatdan commented Feb 2, 2018

Manually merging since Homu seems sick.

@rhatdan rhatdan merged commit a01f708 into containers:master Feb 2, 2018
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@randomvariable @rh-atomic-bot @TomSweeneyRedHat @mheon @rhatdan