Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented May 11, 2018

vendor.conf has been pinned at containerd/cgroups@7a5fdd83 (Merge pull request #26 from onorua/error-ignore-example, 2017-08-24) since libpod forked from CRI-O with a031b83 (Initial checkin from CRI-O repo, 2017-11-01). The content in vendor/github.com/containerd/cgroups was bumped to containerd/cgroups@77e62851 (Use /proc/diskstats to get device names, 2018-01-31) in ae89dc2 (Update containerd/cgroups repo fix perf issue, 2018-02-01, #284), but ae89dc2 forgot to update vendor.conf. With this commit:

$ vndr github.com/containerd/cgroups

no longer changes anything under vendor/github.com/containerd/cgroups.

Spun off from #747.

vendor.conf has been pinned at containerd/cgroups@7a5fdd83 (Merge pull
request containers#26 from onorua/error-ignore-example, 2017-08-24) since libpod
forked from CRI-O with a031b83 (Initial checkin from CRI-O repo,
2017-11-01).  The content in vendor/github.com/containerd/cgroups was
bumped to containerd/cgroups@77e62851 (Use /proc/diskstats to get
device names, 2018-01-31) in ae89dc2 (Update containerd/cgroups repo
fix perf issue, 2018-02-01, containers#284), but ae89dc2 forgot to update
vendor.conf.  With this commit:

  $ vndr github.com/containerd/cgroups

no longer changes anything under vendor/github.com/containerd/cgroups.

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking force-pushed the vendor-containerd-cgroup-cleanup branch from 9d8d99b to 36b0001 Compare May 11, 2018 04:10
@giuseppe
Copy link
Member

LGTM

@mheon
Copy link
Member

mheon commented May 11, 2018

LGTM
@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 36b0001 has been approved by mheon

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 36b0001 with merge f97de48...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: mheon
Pushing f97de48 to master...

@wking wking deleted the vendor-containerd-cgroup-cleanup branch May 11, 2018 16:07
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants