add remote-client diff #2825
Merged
add remote-client diff #2825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
rhatdan
reviewed
Apr 1, 2019
Member
|
bot, retest this please |
Member
|
LGTM |
vrothberg
reviewed
Apr 2, 2019
Member
vrothberg
left a comment
vrothberg
left a comment
There was a problem hiding this comment.
It looks like there is small hiccup with the change types:
[valentin@nebuchadnezzar libpod pull-request-2825 ?]$ sudo ./bin/podman-remote diff 2bcb04bdb83f
ERRO[0000] 'C' is unknown archive type
ERRO[0000] 'C' is unknown archive type
ERRO[0000] 'C' is unknown archive type
C /var/log/nginx
C /var/log/nginx/access.log
C /var/log/nginx/error.log
[valentin@nebuchadnezzar libpod pull-request-2825 ?]$ sudo ./bin/podman diff 2bcb04bdb83f
C /var/log/nginx
C /var/log/nginx/access.log
C /var/log/nginx/error.log
Besides that LGTM.
Member
|
Other than @vrothberg's comment, LGTM assuming happy tests. They're not at the moment fwiw. |
Member
|
LGTM |
Member
|
bot, retest this please |
the remote client now can run the diff command to report changes, modifications, and deletions in an image or container. Signed-off-by: baude <[email protected]>
Member
|
/lgtm |
This was referenced Apr 3, 2019
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the remote client now can run the diff command to report changes,
modifications, and deletions in an image or container.
Signed-off-by: baude [email protected]