-
Notifications
You must be signed in to change notification settings - Fork 3k
Cirrus: Use packaged-based dependencies #1936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus: Use packaged-based dependencies #1936
Conversation
452bc54 to
c65ff39
Compare
|
☔ The latest upstream changes (presumably #1932) made this pull request unmergeable. Please resolve the merge conflicts. |
caef081 to
e778929
Compare
|
N/B: Images built from this PR here: https://cirrus-ci.com/task/6236613032017920 |
e778929 to
a29ff52
Compare
|
Status (Both Fedora 29 and Ubuntu 18.04)
@baude @mheon need some discussion/guidance here, given the frequent "issues" we've hit in PR & Master testing WRT In other words, if a Or (maybe worse), a test which touches a new (not yet available in Are these things actual problems, and something we want to stand in front of as a BTW: I'm open to having two sets of tests, one being package-based, the other running with test-time compiled, "latest-master" version of the direct-dependencies (no sha-binding like before). If this is a better idea, which (or both) should be a gate for PR merges vs just advisory testing? |
e8471cd to
654744c
Compare
|
note to me: Ubuntu fails b/c searching for conmon in deprecated locations. Need something like #3429 to fix. |
654744c to
cad7137
Compare
Building/installing dependencies from fixed source-version ensures testing is reliable, but introduces a maintenance burden and risks testing far outside of a real-world environment. The sensible alternative is to install dependencies from distro-packaging systems. Install all development and testing dependencies at VM cache-image build time, to help ensure testing remains stable. The existing cache-image build workflow can be utilized at any future time to build/test with updated packages. ***N/B***: This does not update any dockerfiles used by testing, that is left up to future efforts. Signed-off-by: Chris Evich <[email protected]>
cad7137 to
3d559df
Compare
|
This is smaller than I thought it would be. A lot easier to review as such. Initial pass, everything seems reasonable. I'd just like @baude to have a look at the Varlink stuff - I know that's a packaging minefield. |
Much of what made this PR so large originally, was split off into XXXL #2561 (already merged) 😄 Having that was absolutely critical for finishing development on this PR. Also critical was all of @haircommander and @lsm5 efforts on splitting/packaging conmon and maintaining the other dependent packages (thanks!). |
|
/lgtm |
This was originally intended, but somehow omitted from containers#1936 Signed-off-by: Chris Evich <[email protected]>
This was originally intended, but somehow omitted from containers#1936 Signed-off-by: Chris Evich <[email protected]>
Building/installing dependencies from fixed source-version ensures
testing is reliable, but introduces a maintenance burden and
risks testing far outside of a real-world environment. The
sensible alternative is to install dependencies from distro-packaging
systems.
Install all development and testing dependencies at cache-image build
time, to help ensure testing remains stable. The existing cache-image
build workflow can be utilized at any future time to build/test
with updated packages.