Skip to content

Conversation

@giuseppe
Copy link
Member

@giuseppe giuseppe commented Dec 4, 2018

inherit a change for rootless containers to ignore devices nodes
inside of images.

Signed-off-by: Giuseppe Scrivano [email protected]

@giuseppe
Copy link
Member Author

giuseppe commented Dec 4, 2018

/test images

@TomSweeneyRedHat
Copy link
Member

Change LGTM, but some tests don't look happy atm.

@mheon
Copy link
Member

mheon commented Dec 4, 2018

LGTM once CI returns to sanity. F28 is just cgroup flake, I'll rerun that one.
/approve

@mheon
Copy link
Member

mheon commented Dec 4, 2018

bot, retest this please

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2018
inherit a change for rootless containers to ignore devices nodes
inside of images.

Signed-off-by: Giuseppe Scrivano <[email protected]>
@baude
Copy link
Member

baude commented Dec 4, 2018

/retest

@mheon
Copy link
Member

mheon commented Dec 4, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2018
@mheon
Copy link
Member

mheon commented Dec 4, 2018

Alright, we've traded ci/prow/images failing for Papr just... not running?

@jlebon
Copy link
Contributor

jlebon commented Dec 4, 2018

bot, retest this please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants